Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UI to make it clear that tags are related to the Stack and not the resource #193

Closed
gavclark opened this issue Nov 6, 2022 · 2 comments
Closed

Update UI to make it clear that tags are related to the Stack and not the resource #193

gavclark opened this issue Nov 6, 2022 · 2 comments
Assignees
@dlpzx
Labels
status: in-review This issue has been implemented and is currently in review and waiting for next release type: enhancement Feature enhacement
Milestone
v1.3.0

Comments

@gavclark
Copy link

gavclark commented Nov 6, 2022

Is your idea related to a problem? Please describe.
When maintaining tags in data.all UI for a resource (e.g., pipeline) , it is not immediately obvious that you are actually maintaining the tags for the CloudFormation stack.

Describe the solution you'd like
Possibly have some title in the tag maintenance screen that says it is Stack tags, or change the text of the button to say "Add/Edit Stack Tags"

image

P.S. Don't attach files. Please, prefer add code snippets directly in the message body.
@gavclark gavclark added the type: enhancement Feature enhacement label Nov 6, 2022
@dlpzx dlpzx self-assigned this Nov 7, 2022
@dlpzx
Copy link
Contributor

dlpzx commented Nov 7, 2022

Sure this is an easy enhancement, I will pick it up. Thanks for the feedback

@dlpzx dlpzx mentioned this issue Nov 7, 2022
Closed
@dlpzx dlpzx linked a pull request Nov 8, 2022 that will close this issue
v1.2.0 release #185
Merged
@dlpzx dlpzx removed a link to a pull request Nov 8, 2022
v1.2.0 release #185
Merged
@dlpzx dlpzx mentioned this issue Nov 9, 2022
Merged
@dlpzx dlpzx added this to the v1.3.0 milestone Nov 14, 2022
@dlpzx
Copy link
Contributor

dlpzx commented Nov 21, 2022

Included in next release v1.3.0

@dlpzx dlpzx added the status: in-review This issue has been implemented and is currently in review and waiting for next release label Nov 21, 2022
@dlpzx dlpzx mentioned this issue Dec 12, 2022
Merged
dlpzx added a commit that referenced this issue Dec 16, 2022
@dlpzx @noah-paige
@dependabot @mgwidmann
V1.3.0 Features (#248)
f100e05 
### Feature or Bugfix
- Feature

### Detail
- Data.all pipelines enhacements and handle update #230 
- Introduction of Consumer roles to ease data consumption #231 
- Configurable Inheritance of Environment tags #203 
- Configurable Quicksight reader vs anonymous sessions #218 

### Relates
- #230 
- #187 
- #174 
- #193 
- #205 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Noah Paige <noahpaig@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Widmann <mgwidmann@gmail.com>
Co-authored-by: Noah Paige <69586985+noah-paige@users.noreply.github.com>
@dlpzx dlpzx closed this as completed Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlpzx dlpzx

Labels
status: in-review This issue has been implemented and is currently in review and waiting for next release type: enhancement Feature enhacement
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
2 participants
@gavclark @dlpzx