Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe removal of consumption roles with open share requests #450

Closed
dlpzx opened this issue May 11, 2023 · 0 comments · Fixed by #485
Closed

Safe removal of consumption roles with open share requests #450

dlpzx opened this issue May 11, 2023 · 0 comments · Fixed by #485
Labels
priority: medium status: in-progress This issue has been picked and is being implemented type: bug Something isn't working

Comments

@dlpzx
Copy link
Contributor

dlpzx commented May 11, 2023

Is your idea related to a problem? Please describe.
When we remove a consumption role we need to check if there are open share requests for that consumption role otherwise listing shares will fail as it points to unexisting consumption roles

Describe the solution you'd like
A clear and concise description of what you want to happen.

P.S. Don't attach files. Please, prefer add code snippets directly in the message body.
@dlpzx dlpzx added type: bug Something isn't working status: in-progress This issue has been picked and is being implemented priority: medium labels May 11, 2023
@dlpzx dlpzx mentioned this issue May 11, 2023
Closed
@dlpzx dlpzx mentioned this issue May 30, 2023
Merged
@dlpzx dlpzx linked a pull request May 30, 2023 that will close this issue
fix: safe removal of consumption roles with open share requests #485
Merged
@dlpzx dlpzx closed this as completed in #485 Jun 1, 2023
dlpzx added a commit that referenced this issue Jun 1, 2023
@dlpzx
fix: safe removal of consumption roles with open share requests (#485)
fa45abd 
### Feature or Bugfix
- Bugfix

### Detail
- Added check and exception if there are open share requests on a
consumption role or on a group that we are removing from an environment

### Relates
- #450 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: medium status: in-progress This issue has been picked and is being implemented type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: safe removal of consumption roles with open share requests data-dot-all/dataall
1 participant
@dlpzx