-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict NACL rules for backend VPC #487
Labels
Comments
dlpzx
added
type: enhancement
Feature enhacement
status: in-progress
This issue has been picked and is being implemented
priority: high
labels
May 31, 2023
After testing the solution, I was able to confirm that data.all works correctly with the following NACL rules: In addition we need to modify STS boto3 calls because for global VPC endpoints without the region it is not possible to resolve it (related to #144)
|
dlpzx
added a commit
that referenced
this issue
Jul 11, 2023
### Feature or Bugfix - Feature ### Detail - Replace NACL Rules on VPC Subnet with individual security groups defined for the backend VPC as restrictive as possible, allowing only the needed traffic. ### Relates - #487 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: chamcca <40579012+chamcca@users.noreply.github.com> Co-authored-by: dlpzx <71252798+dlpzx@users.noreply.github.com> Co-authored-by: Nikita Podshivalov <nikpodsh@amazon.com>
Implemented as part of v1.6 |
noah-paige
removed
the
status: in-progress
This issue has been picked and is being implemented
label
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current VPC deployed by data.all defines inbound and outbound rules open to all traffic.
What we would like is to have the rules defined as restrictive as possible, allowing only the needed traffic.
The text was updated successfully, but these errors were encountered: