Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capability on Data.all to allow changing the owner for a consumption role without deleting and recreating the role. #870

Closed
mourya-33 opened this issue Nov 14, 2023 · 2 comments · Fixed by #1020
Closed

Add capability on Data.all to allow changing the owner for a consumption role without deleting and recreating the role. #870

mourya-33 opened this issue Nov 14, 2023 · 2 comments · Fixed by #1020
Assignees
@petrkalos
Labels
effort: low priority: medium type: enhancement Feature enhacement

Comments

@mourya-33
Copy link
Contributor

Is your idea related to a problem? Please describe.
Data.all currently does not support any updates for the owners on the consumption role. For any change, the consumption role has to be deleted and recreated with the new owner association.

  1. Navigate to Environments > Teams and add consumption role.
  2. The role will prompt to select an owner from the drop down menu. Select an owner and click on "Add Consumption Role"

The role gets created. To re assign a different owner for the role, there is no provision to edit the consumption role. The only option currently is to delete the consumption role and recreate it by choosing the new owner from the drop down menu again.

Describe the solution you'd like
Add capability on the UI to allow the admins to edit the consumption role and map it to a different owner.
@mourya-33 mourya-33 mentioned this issue Nov 14, 2023
Closed
@dlpzx
Copy link
Contributor

dlpzx commented Nov 27, 2023

Hi @mourya-33, thanks for raising an issue. The fix is relatively easy to implement so we will try to add it to our roadmap as soon as possible. In case you want to give it a try, let us know and we can indicate you how to start this feature.

@dlpzx
Copy link
Contributor

dlpzx commented Jan 29, 2024

We are currently working on it, PR will come shortly

@petrkalos petrkalos mentioned this issue Jan 30, 2024
Merged
petrkalos added a commit that referenced this issue Feb 7, 2024
@petrkalos
adding update consumption role capability (#1020)
d86c07f 
### Feature or Bugfix

- Feature


### Detail
- Add capability to update consumption role owner and name
- Setting the paradigm to use [DataGrid (with edit/CRUD
ops)](https://v5.mui.com/x/react-data-grid/editing/#full-featured-crud-component)
instead of Table

### Relates
- Resolves #870 

### Security
Please answer the questions below briefly where applicable, or write
`N/A`. Based on
[OWASP 10](https://owasp.org/Top10/en/).

### Testing

Tested with multiple accounts and roles
* Locally
* AWS account
* Added unit-tests
* Mocked the entire `sts` client as the tests were sending request to
AWS

- Does this PR introduce or modify any input fields or queries - this
includes
fetching data from storage outside the application (e.g. a database, an
S3 bucket)?
  - Is the input sanitized?
- What precautions are you taking before deserializing the data you
consume?
  - Is injection prevented by parametrizing queries?
  - Have you ensured no `eval` or similar functions are used?
- Does this PR introduce any functionality or component that requires
authorization?
- How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  - Are you logging failed auth attempts?
- Are you using or adding any cryptographic features?
  - Do you use a standard proven implementations?
  - Are the used keys controlled by the customer? Where are they stored?
- Are you introducing any new policies/roles/users?
  - Have you used the least-privilege principle? How?


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Co-authored-by: Petros Kalos <kalosp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petrkalos petrkalos

Labels
effort: low priority: medium type: enhancement Feature enhacement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adding update consumption role capability petrkalos/dataall
4 participants
@petrkalos @dlpzx @anmolsgandhi @mourya-33