Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network drop down selection on Notebook creation page #983

Closed
awskaran opened this issue Jan 18, 2024 · 2 comments · Fixed by #986
Closed

Network drop down selection on Notebook creation page #983

awskaran opened this issue Jan 18, 2024 · 2 comments · Fixed by #986
Labels
type: bug Something isn't working
Milestone

Comments

@awskaran
Copy link
Contributor

Is your idea related to a problem? Please describe.
When creating a notebook from the UI, user needs to add a VPC ID and Subnet ID which if not communicated by the admin is difficult for users to get hold off unless they have access to AWS console and understand how to navigate it.

Describe the solution you'd like
I want the UI to present me with a drop down selection of VPC ID and Subnet IDs while creating the Notebook, once I have made the Environment selection on the Deployment pane.
The UI should make the options available based on the network setup added at the Environment level.
Ideally the subnet list should be restricted to private subnets

P.S. Don't attach files. Please, prefer add code snippets directly in the message body.
image

@dlpzx dlpzx added the type: bug Something isn't working label Jan 18, 2024
@dlpzx
Copy link
Contributor

dlpzx commented Jan 18, 2024

Hi @awskaran, I found the issue! It is a small bug introduced with v2 changes. We will fix it as soon as possible. Thanks for pointing it out.

@enr0c
Copy link

enr0c commented Jan 18, 2024

Great:) This one was bothering me as well;) I thoughts it has been a feature rather than a bug, but now that its fixed, i am looking very much forward to it!

@noah-paige noah-paige linked a pull request Jan 19, 2024 that will close this issue
noah-paige added a commit that referenced this issue Jan 19, 2024
### Feature or Bugfix
- Bugfix

### Detail
Missing API output definition to list environment networks in creation
of notebooks

### Relates
- #983 

### Security
Please answer the questions below briefly where applicable, or write
`N/A`. Based on
[OWASP 10](https://owasp.org/Top10/en/).

- Does this PR introduce or modify any input fields or queries - this
includes
fetching data from storage outside the application (e.g. a database, an
S3 bucket)?
  - Is the input sanitized?
- What precautions are you taking before deserializing the data you
consume?
  - Is injection prevented by parametrizing queries?
  - Have you ensured no `eval` or similar functions are used?
- Does this PR introduce any functionality or component that requires
authorization?
- How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  - Are you logging failed auth attempts?
- Are you using or adding any cryptographic features?
  - Do you use a standard proven implementations?
  - Are the used keys controlled by the customer? Where are they stored?
- Are you introducing any new policies/roles/users?
  - Have you used the least-privilege principle? How?


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Co-authored-by: Noah Paige <noahpaig@amazon.com>
@noah-paige noah-paige added this to the v2.3.0 milestone Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants