Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset Description on shares UI page #1026

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

TejasRGitHub
Copy link
Contributor

@TejasRGitHub TejasRGitHub commented Jan 31, 2024

Feature or Bugfix

  • Feature

Detail

As described by the problem in this GH issue - #1025 . This will add dataset description on the shares UI page.

Testing

  1. Created a share for a dataset
  2. Shares Page now contains the dataset description in the UI

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)? No
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization? No
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features? No
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored? No
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx
Copy link
Contributor

dlpzx commented Feb 1, 2024

Hi @TejasRGitHub I have deployed the PR in an AWS account, here is how the UI looks like:
image

The whole share view is starting to look a bit crowded, maybe we can get together and design how we want it to look like

@TejasRGitHub
Copy link
Contributor Author

TejasRGitHub commented Feb 1, 2024

@dlpzx , Yes we can get together and discuss how the UI/UX would be much better.

For the time-being , as this feature would help us. If its okay and you think it will be helpful, we can add this to the main branch.

Also, made changes to the code to show "No description for dataset" when there isn't one .
image

@dlpzx dlpzx merged commit 559f85e into data-dot-all:main Feb 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants