[GH-1027] - Adding cloudformation permission to PivotRoleNestedStack #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpzx
reviewed
Feb 12, 2024
| Resource: !Sub 'arn:${AWS::Partition}:cloudformation:${AWS::Region}:${AWS::AccountId}:stack/CDKToolkit/*' | ||
| Resource: | ||
| - !Sub 'arn:${AWS::Partition}:cloudformation:${AWS::Region}:${AWS::AccountId}:stack/CDKToolkit/*' | ||
| - !Sub 'arn:${AWS::Partition}:cloudformation:${AWS::Region}:${AWS::AccountId}:stack/*PivotRoleStackNestedStack*' |
There was a problem hiding this comment.
we could make it more generic and restrict by dataall prefixed stacks instead of by pivot role stacks. That way we really point to data.all stacks. Wdyt?
There was a problem hiding this comment.
agreed - think restricting as described above would be best. It would be by env resource prefix and not necessarily dataall right?
There was a problem hiding this comment.
Agreed! Shall I provide another Update on the same PR ? @dlpzx
Asking because the PR is approved
There was a problem hiding this comment.
Yes, I re-requested my review again. Wrong button :S
There was a problem hiding this comment.
Updated with the environment prefix 😄 , @dlpzx , @noah-paige
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Adding cloudformation permission to PivotRoleNestedStack
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)? NO
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.