Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

922 - Replace IAM inline policies by configurable Managed Policies for folder and bucket sharing #1068

Merged
merged 61 commits into from
Mar 4, 2024
Merged

922 - Replace IAM inline policies by configurable Managed Policies for folder and bucket sharing #1068

merged 61 commits into from
Mar 4, 2024

Commits on Jan 30, 2024

  1. added 'create_managed_policy' method to base IAM class

    Sofia Sazonova committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    5d876ec View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Merge branch 'mda-main' into 922-consumer-ima-role

    Sofia Sazonova committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    43d0557 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. generate empty policies, when the cosumption role is added

    Sofia Sazonova committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d7145ff View commit details
    Browse the repository at this point in the history

  2. detach|delete|update managed policies for consumption roles

    Sofia Sazonova committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    7ecb809 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. add permissions to pivot role to create and attach managed policies

    Sofia Sazonova committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    c33a547 View commit details
    Browse the repository at this point in the history

  2. fatal typo. Corrected: uri -> env_uri

    Sofia Sazonova committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    08df323 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. ensure always consumptionRoleName and not IAMRoleName is used

    Sofia Sazonova committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    06a87d9 View commit details
    Browse the repository at this point in the history

  2. lint

    Sofia Sazonova committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    d44409d View commit details
    Browse the repository at this point in the history

  3. compose managed policy arn by name and account_id

    Sofia Sazonova committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    3db3664 View commit details
    Browse the repository at this point in the history

  4. detach pilicies from role by IAM role name, not by consumption_role_name

    Sofia Sazonova committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    342fa83 View commit details
    Browse the repository at this point in the history

  5. lint

    Sofia Sazonova committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    71b9445 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. adjsut share_managers to work with managed policies instead of inline… 

    … policies. Adjust tests
    Sofia Sazonova committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    7ccd505 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. check if the required policies are attached to consumer role before s… 

    …haring
    Sofia Sazonova committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    0c881b9 View commit details
    Browse the repository at this point in the history

  2. Flag dataallManaged for the consumptionRoles + migrations. Front-end … 

    …switch
    Sofia Sazonova committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    18c69c8 View commit details
    Browse the repository at this point in the history

  3. frontend and test fix

    Sofia Sazonova committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    49f3e05 View commit details
    Browse the repository at this point in the history

  4. Block share create if there are no policies attached to consumption role

    Sofia Sazonova committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d4875e0 View commit details
    Browse the repository at this point in the history

  5. raise class Exception

    Sofia Sazonova committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    4649b18 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. add permissions to pivot role and more logging

    Sofia Sazonova committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    6b6702f View commit details
    Browse the repository at this point in the history

  2. add permissions to pivot role for Add and Delete policy versions

    Sofia Sazonova committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    a9fbc00 View commit details
    Browse the repository at this point in the history

  3. auto-aplly policies, if user checked this option. Display dataallMana… 

    …ged flags in consumption roles table
    Sofia Sazonova committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    93b6f3a View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. field dataallManaged typo fix. 

    + frontend adjustments
    Sofia Sazonova committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    b9f5ef4 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. use just one share policy per consumption role 

    add frontend fields for consumption roles
    Sofia Sazonova committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    645ea5e View commit details
    Browse the repository at this point in the history

  2. For Group-role the share policies are also attached 

    Frontend display of share policies
    Sofia Sazonova committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    3ab0988 View commit details
    Browse the repository at this point in the history

  3. lint fix

    Sofia Sazonova committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    6a30a1a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'mda-main' into 922-consumer-ima-role

    Sofia Sazonova committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    da1a3ee View commit details
    Browse the repository at this point in the history

  5. Revert Makefile as it was

    Sofia Sazonova committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    a633747 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Checkov baseline supression of 'CKV_AWS_110' for PivotRolepolicy3. ia… 

    …m:AttachPolicy is necessary
    Sofia Sazonova committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    8fa4cf9 View commit details
    Browse the repository at this point in the history

  2. disable 'Send request' button, if the policy is not attached

    Sofia Sazonova committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    73d44ad View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Merge branch 'mda-main' into 922-consumer-ima-role

    Sofia Sazonova committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    f202ddb View commit details
    Browse the repository at this point in the history

  2. Merge of alembic migrations

    Sofia Sazonova committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9491131 View commit details
    Browse the repository at this point in the history

  3. dataallManaged for ConsumptionRole is set to True by default

    Sofia Sazonova committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    72c4e92 View commit details
    Browse the repository at this point in the history

  4. Correct typo sharePolicyRolName -> sharePolicyRoleName

    Sofia Sazonova committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    17f9cb8 View commit details
    Browse the repository at this point in the history

  5. Remove ridiculous fields from ConsumptionRoleSearchResult

    Sofia Sazonova committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e771dd1 View commit details
    Browse the repository at this point in the history

  6. All share policy stuff for environment is now in separate service

    Sofia Sazonova committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    dfc9784 View commit details
    Browse the repository at this point in the history

  7. Backwords compatibility

    Sofia Sazonova committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    cbe9d6d View commit details
    Browse the repository at this point in the history

  8. If there were no inline share policies, we add no resources

    Sofia Sazonova committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    38feb93 View commit details
    Browse the repository at this point in the history

  9. resolver for ConsumptionRole properties

    Sofia Sazonova committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    d2b1657 View commit details
    Browse the repository at this point in the history

  10. small changes

    Sofia Sazonova committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a31ec06 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Merge branch 'main' into 922-consumer-ima-role

    @dlpzx
    dlpzx committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    964b44c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'sof/922-consumer-ima-role' into 922-con… 

    …sumer-ima-role
    @dlpzx
    dlpzx committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    4bdab88 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. ManagedPolicies to decouple SharePolicy service from core, backwards … 

    …compatibility
    @dlpzx
    dlpzx committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    73b9caa View commit details
    Browse the repository at this point in the history

  2. Fix alembic migration script

    @dlpzx
    dlpzx committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a9c8a64 View commit details
    Browse the repository at this point in the history

  3. Implementation with abstract classes instead. Added class to data sha… 

    …ring init
    @dlpzx
    dlpzx committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    92b98d3 View commit details
    Browse the repository at this point in the history

  4. Uncoupled sharing policies from frontend

    @dlpzx
    dlpzx committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e7d5571 View commit details
    Browse the repository at this point in the history

  5. Added externally managed policies to environment stack to handle non-… 

    …imported roles
    @dlpzx
    dlpzx committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    77b9982 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Fix non-imported IAM roles and clear commented backwards compatibilit… 

    …y snippets
    @dlpzx
    dlpzx committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    abdeddd View commit details
    Browse the repository at this point in the history

  2. Divided policies for access points and buckets. Merge ShareManagerUti… 

    …ls into SharePolicy service
    @dlpzx
    dlpzx committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c53dd9e View commit details
    Browse the repository at this point in the history

  3. Fix tests, added methods in remove group from environment and in crea… 

    …te/delete environment
    @dlpzx
    dlpzx committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    785d002 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Revert changes for environment creation

    @dlpzx
    dlpzx committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    45278d9 View commit details
    Browse the repository at this point in the history

  2. Replace FAKE_S3_PLACEHOLDER by EMPTY_STATEMENT

    @dlpzx
    dlpzx committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    2484ea2 View commit details
    Browse the repository at this point in the history

  3. Scope down permissions for pivot role

    @dlpzx
    dlpzx committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    8fee408 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into 922-consumer-ima-role 

    # Conflicts:
#	backend/dataall/modules/dataset_sharing/api/input_types.py
#	backend/dataall/modules/dataset_sharing/services/share_managers/s3_access_point_share_manager.py
#	backend/dataall/modules/dataset_sharing/services/share_managers/s3_bucket_share_manager.py
#	backend/dataall/modules/dataset_sharing/services/share_managers/share_manager_utils.py
#	backend/dataall/modules/dataset_sharing/services/share_object_service.py
#	backend/dataall/modules/dataset_sharing/services/share_processors/s3_bucket_process_share.py
#	tests/modules/datasets/tasks/test_s3_access_point_share_manager.py
#	tests/modules/datasets/tasks/test_s3_bucket_share_manager.py
    @dlpzx
    dlpzx committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    a7ae29e View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Adapt to merge changes

    @dlpzx
    dlpzx committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    181af2a View commit details
    Browse the repository at this point in the history

  2. Added exception handling, added and fixed tests

    @dlpzx
    dlpzx committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    65cf21a View commit details
    Browse the repository at this point in the history

  3. Fix test

    @dlpzx
    dlpzx committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    11ae8e1 View commit details
    Browse the repository at this point in the history

  4. Fix credentials tests

    @dlpzx
    dlpzx committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    b896e1f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Small review enhancements

    @dlpzx
    dlpzx committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    974949d View commit details
    Browse the repository at this point in the history

  2. Add edge cases support: delete policy versions, check policies before… 

    … delete, exceptions in environment stack
    @dlpzx
    dlpzx committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a767146 View commit details
    Browse the repository at this point in the history

  3. Fixes backwards compatibility - remove backfilling from environment s… 

    …tack
    @dlpzx
    dlpzx committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    3ae6892 View commit details
    Browse the repository at this point in the history

  4. Flaking

    @dlpzx
    dlpzx committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b96871c View commit details
    Browse the repository at this point in the history

  5. update checkov and small typo

    @noah-paige
    noah-paige committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    3a10763 View commit details
    Browse the repository at this point in the history