Solving issue with worksheets for catalog Dbs #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # backend/dataall/modules/dataset_sharing/services/share_item_service.py # backend/dataall/modules/dataset_sharing/services/share_object_service.py # tests/modules/datasets/test_share.py
noah-paige
reviewed
Mar 4, 2024
backend/dataall/modules/dataset_sharing/services/share_item_service.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
When using worksheet with a share made with a catalog account ( by using steps as described here in this PR - #1021 ) , the worksheet drop down list doesn't display the correct DB name. This is due to the fact that DB name is picked from the producer account ( where the S3 bucket is present and where the actualDB is not present ) which has the resource linked DB. Thus, the autogenerated querying doesn't work . Please refer to the screenshot
Also, on the share view, the db name mentioned on the query ( in the "Data Consumption details" ) is the resource linked DB name and not the correct DB name.
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)? No
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.