Refactor core/environment&stack module - part 2 #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2024 13:02
Remove queries from stack/api/resolvers
dlpzx
reviewed
Apr 12, 2024
| @@ -63,7 +63,7 @@ def update_stack_output(session, stack): | |||
| aws = SessionHelper.remote_session(stack.accountid, stack.region) | |||
| cfn = aws.resource('cloudformation', region_name=stack.region) | |||
| try: | |||
| stack_outputs = cfn.Stack(f'{stack.name}').outputs | |||
| stack_outputs = cfn.StackRepository(f'{stack.name}').outputs | |||
There was a problem hiding this comment.
This is not referring to the data.all Stack class but to the aws resource cfn.Stack!
There was a problem hiding this comment.
Oh, the naming was confusing...
dlpzx
reviewed
Apr 12, 2024
| @@ -26,11 +26,12 @@ from aws_cdk import ( | |||
| ) | |||
| from dataall.base.cdkproxy.stacks import stack | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
this is also not refering to the StackRepository but to aws_cdk.Stack.
The whole block should be:
from aws_cdk import (
aws_s3 as s3,
aws_sqs as sqs,
core,
Stack
)
@stack(stack="mypredefinedstack")
class MyPredefinedStack(Stack):
def __init__(self, scope, id, **kwargs):
super().__init__(scope, id, **kwargs)
# constructs goes here
dlpzx
reviewed
Apr 12, 2024
| @@ -435,8 +435,8 @@ def _deploy_dataset_stack(dataset: Dataset): | |||
| stack_helper.deploy_stack(dataset.environmentUri) | |||
|
|
|||
| @staticmethod | |||
| def _create_dataset_stack(session, dataset: Dataset) -> Stack: | |||
| return Stack.create_stack( | |||
| def _create_dataset_stack(session, dataset: Dataset) -> StackRepository: | |||
There was a problem hiding this comment.
This function should return a Stack model from dataall/core/stacks/db/stack_models.py
dlpzx
requested changes
Apr 12, 2024
added 2 commits
April 12, 2024 15:49
This reverts commit 0d25401.
|
Tested changes locally and created an environment - all functionality working as expected Think just need to fix the |
dlpzx
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.