Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Change to use s3 access point while sharing folders #117

Conversation

LEUNGUU
Copy link
Contributor

@LEUNGUU LEUNGUU commented Aug 31, 2022

Feature or Bugfix

  • Feature

Detail

  1. Change to use s3 access point to control access for the bucket.
    • One access point will be created for one team per dataset.
    • Delegate access control for a bucket to the bucket's access points.
    • Manipulate access point policy and target role policy to do the magic of sharing.
    • Update bucket KMS key policy for decryption and downloading sharing objects.
    • Add revoke permissions and cleanup sharing actions.
  2. Remove trigger dataset stack deployment when doing sharing.

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LEUNGUU LEUNGUU force-pushed the feat/replace-s3-bucketpolicy-with-accesspoints branch 3 times, most recently from 2db387f to b37c501 Compare September 13, 2022 02:58
@dlpzx dlpzx self-requested a review September 13, 2022 06:38
@LEUNGUU LEUNGUU force-pushed the feat/replace-s3-bucketpolicy-with-accesspoints branch from b37c501 to e4f4ccb Compare September 14, 2022 06:50
@LEUNGUU LEUNGUU changed the base branch from main to v.1.2.0 September 14, 2022 07:46
@LEUNGUU LEUNGUU changed the title [WIP] Feature: Change to use s3 access point while sharing folders Feature: Change to use s3 access point while sharing folders Sep 14, 2022
@dlpzx dlpzx deleted the branch data-dot-all:v.1.2.0 September 19, 2022 15:54
@dlpzx dlpzx closed this Sep 19, 2022
@dlpzx dlpzx reopened this Sep 19, 2022
@dlpzx dlpzx merged commit 33bd1d3 into data-dot-all:v.1.2.0 Sep 19, 2022
@dlpzx dlpzx mentioned this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants