Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement less restrictive trust policy for local development pivot roles #1176

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Apr 15, 2024

Feature or Bugfix

  • Feature

Detail

When the environment is local (local deployment using docker), the pivot role that is created has a more open trust policy. Instead of restricting with externalId and naming conventions, the local pivot role can be assumed by the credentials account.

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)? N/A.
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization? N/A.
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features? N/A.
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users? ---> ⚠️ Yes, in this PR the trust policy for the pivot role created by CDK in the data.all local environment changes. The trust policy for AWS deployments stays the same
    • Have you used the least-privilege principle? How? ---> the change only affects local deployment where the trust policy requirements can be more relaxed because it is going to be used by developers to develop locally

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx requested a review from petrkalos April 15, 2024 13:45
Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally - updates role properly

looks good!

f'arn:aws:iam::{principal_id}:role/*awsworker-role',
f'arn:aws:iam::{principal_id}:role/*ecs-tasks-role',
]
if ENVNAME == 'local':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to derail your PR but our code is full of these checks. Would you mind creating a bunch of util methods (is_local is_prod is_docker etc)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do on a separate PR, good idea!

@dlpzx dlpzx merged commit ea0dd3b into main Apr 16, 2024
9 checks passed
@dlpzx dlpzx deleted the feat/local-deployment-simplification branch April 25, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants