Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version auth at edge to use node v20 #1327

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

noah-paige
Copy link
Contributor

Feature or Bugfix

  • Enhancement

Detail

  • Update serverless application Auth At Edge to use node v20

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@noah-paige noah-paige self-assigned this Jun 11, 2024
@noah-paige noah-paige linked an issue Jun 11, 2024 that may be closed by this pull request
@noah-paige
Copy link
Contributor Author

noah-paige commented Jun 11, 2024

Tested in AWS to ensure:

  • Clean Upgrade via CodePipeline
  • Node version for AuthAtEdge Lambda Functions updated to v20
  • UserGuide still accessible with required user login creds

Copy link
Contributor

@petrkalos petrkalos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case you haven't already can you also test the following scenarios

  • fresh login from an incognito tab
  • logout and login again

@noah-paige
Copy link
Contributor Author

in case you haven't already can you also test the following scenarios

* fresh login from an incognito tab

* logout and login again

Tested and all working as expected

@noah-paige noah-paige merged commit abdd9e8 into main Jun 11, 2024
10 checks passed
@dlpzx dlpzx deleted the update/auth-at-edge-version branch June 26, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade lambdas using v16 Node.js runtime
3 participants