Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search (Autocomplete) in environment/group dropdown in Share request modal #1335

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Jun 17, 2024

Feature or Bugfix

  • Feature

Detail

In the following view, instead of using a fixed list in the environment, team and consumption roles dropdowns; this PR introduces search capabilities as requested in #1012. There are still many other dropdowns to change, where we will be able to extract a common frontend component. This one however, is a bit particular so I implemented it separately.

image

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx marked this pull request as ready for review June 17, 2024 16:51
@dlpzx dlpzx marked this pull request as draft June 17, 2024 16:56
@dlpzx
Copy link
Contributor Author

dlpzx commented Jun 17, 2024

Tested locally:

  • Happy path: new share request - select an environment, select a group, submit
  • Happy path2: new share request - select an environment, select a group, select a consumption role, submit
  • Select environment, click on cross in environment ---> removes environment and group options
  • Select environment, select group, click on cross in group ---> removes group and consumption role options
  • Select environment, select group, click on cross in environment ---> removes environment and group and consumption role options
  • Select environment, overwrite it with some random string --> throws validation error
  • Select group overwrite it with some random string --> throws validation error
  • Select comsumption, overwrite it with some random string --> throws validation error (DOES NOT OPEN REQUEST FOR GROUP)

Recording of the tests:
https://github.com/data-dot-all/dataall/assets/71252798/9be9df59-1ed7-4fbb-aaf2-2dcede457e53

…eat/search-env-dropdown

# Conflicts:
#	frontend/src/modules/Catalog/components/RequestAccessModal.js
Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - approving

tested locally as well!

@dlpzx dlpzx merged commit cfa1e31 into main Jun 20, 2024
9 checks passed
dlpzx added a commit that referenced this pull request Jun 25, 2024
…ort forms (#1347)

### Feature or Bugfix
- Feature

### Detail
Autocomplete for environments and teams in the following frontend views
as requested in 1012.

This PR introduces a 2 new Shared frontend components:
EnvironmentTeamDropdown and EnvironmentTeamDatasetsDropdown. They are
generic formik fields that can be reused in Formik forms in several
modules. Some creation forms include custom parameters that are fetched
alongside the environments and teams (e.g. Notebooks sets VPCs). For
those cases, we implement the Autocomplete logic in the view itself

- [X] DashboardImportForm.js - using EnvironmentTeamDropdown
- [X] MLStudioCreateForm.js - using EnvironmentTeamDropdown
- [X] NotebookCreateForm.js - custom
- [X] OmicsRunCreateForm.js - using EnvironmentTeamDatasetsDropdown
- [X] DatasetCreateForm.js - custom
- [X] DatasetImportForm.js - custom

Pipelines in a separate PR

In all forms we use `SamlAdminGroupName` instead of `SamlGroupName` as a
standard that allows us to use Shared components

### Relates
- #1335
- #1012 


### Security
Please answer the questions below briefly where applicable, or write
`N/A`. Based on
[OWASP 10](https://owasp.org/Top10/en/).

- Does this PR introduce or modify any input fields or queries - this
includes
fetching data from storage outside the application (e.g. a database, an
S3 bucket)?
  - Is the input sanitized?
- What precautions are you taking before deserializing the data you
consume?
  - Is injection prevented by parametrizing queries?
  - Have you ensured no `eval` or similar functions are used?
- Does this PR introduce any functionality or component that requires
authorization?
- How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  - Are you logging failed auth attempts?
- Are you using or adding any cryptographic features?
  - Do you use a standard proven implementations?
  - Are the used keys controlled by the customer? Where are they stored?
- Are you introducing any new policies/roles/users?
  - Have you used the least-privilege principle? How?


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
@dlpzx dlpzx deleted the feat/search-env-dropdown branch June 26, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants