Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gql apis + update_environment tests #1348

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

petrkalos
Copy link
Contributor

@petrkalos petrkalos commented Jun 19, 2024

Feature or Bugfix

  • Bugfix

Detail

  • update integ tests gql apis
  • add update_environment tests
  • misc improvements

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@petrkalos petrkalos force-pushed the fix/integ_tests_new_api branch 2 times, most recently from 00cc80a to ab981bd Compare June 19, 2024 13:27
@petrkalos petrkalos requested a review from dlpzx June 19, 2024 13:53
@petrkalos petrkalos force-pushed the fix/integ_tests_new_api branch 2 times, most recently from d68a172 to 738db6b Compare June 20, 2024 07:39
Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the session_id tags used for filtering the organizations; very smart

@petrkalos petrkalos merged commit 9ceac71 into main Jun 21, 2024
9 checks passed
@petrkalos petrkalos deleted the fix/integ_tests_new_api branch June 21, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants