Share UI Submit fix #1403
Merged
Share UI Submit fix #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noah-paige
reviewed
Jul 11, 2024
| const handlePageChange = async (event, value) => { | ||
| if (value <= sharedItems.pages && value !== sharedItems.page) { | ||
| await setFilter({ ...filter, page: value }); | ||
| } | ||
| }; | ||
|
|
||
| const beforeClose = async () => { | ||
| if (smthChanged || requestPurpose !== share.requestPurpose) { | ||
| if (requestPurpose !== share.requestPurpose) { |
There was a problem hiding this comment.
need to add setSmthChanged(true); for if no response errors for updateRequestPurpose then
There was a problem hiding this comment.
updateRequestPurpose doesn't change the state of Share. So, basically, there is nothing to submit.
There was a problem hiding this comment.
@noah-paige may be we should change that, but not before 2.6
There was a problem hiding this comment.
onApply just refreshed the ShareObject and associated share items in the view right?
If we do not run onApply() then I can update the request purpose --> hit Save & Close --> the share view is not updated and the old request purpose still shows
There was a problem hiding this comment.
Hm, yes, you are right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.