Feat/integ tests notifications #1597
Conversation
| assert_that(list_notifications(client1, filter={'read': True})).is_not_none() | ||
| assert_that(list_notifications(client1, filter={'unread': True})).is_not_none() | ||
| assert_that(list_notifications(client1, filter={'archived': True})).is_not_none() | ||
|
|
||
|
|
||
| def test_count_unread_notification(client1, session_share_1): | ||
| def test_count_unread_notification(client1): | ||
| assert_that(count_unread_notificiations(client1)).is_greater_than_or_equal_to(0) | ||
|
|
||
|
|
There was a problem hiding this comment.
countReadNotifications and countDeletedNotifications are not used in the frontend. Maybe we should delete them from the backend and remove the tests for countReadNotifications. wdyt?
There was a problem hiding this comment.
deleteNotification is also not used in the frontend
There was a problem hiding this comment.
removed all 3 ops
| response = client.query(query=query) | ||
| return response.data.countUnreadNotifications | ||
|
|
||
|
|
There was a problem hiding this comment.
As commented already, count_read_notificiations and count_deleted_notificiations are not used in the FE
There was a problem hiding this comment.
removed all 3 ops
| assert_that(list_notifications(client1)).is_not_none() | ||
| assert_that(list_notifications(client1, filter={'read': True})).is_not_none() | ||
| assert_that(list_notifications(client1, filter={'unread': True})).is_not_none() | ||
| assert_that(list_notifications(client1, filter={'archived': True})).is_not_none() |
There was a problem hiding this comment.
Maybe we can assert the keys of the response, not only that it is not None
There was a problem hiding this comment.
asserted contains_key(...)
Is there another PR for shares that I should wait for on shares before testing once more that all shares tests + notification tests work in tandem? @dlpzx |
Feature or Bugfix
Detail
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.