-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor env permissions + modify getTrustAccount #1712
Conversation
8305aa4
to
f7ce0c4
Compare
f7ce0c4
to
1e0d54f
Compare
createQuicksightDataSourceSet, | ||
getMonitoringDashboardId, | ||
getMonitoringVPCConnectionId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existed before but all of the following use ParameterStore and try to assume into pivotRole in infra account to get SSM (pivot role DNE in infra account)
- createQuicksightDataSourceSet,
- getMonitoringDashboardId,
- getMonitoringVPCConnectionId,
- updateSSMParameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment on QS Monitoring feature - but refactoring looks good
Can you list testing you've done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
(1) Do we want to clean up
getPlatformAuthorSession
- do not believe it is used anywhere now -
(2) I know not the primary focus of this PR but want to call out that when checking if the APIs used in
AdministratorDasbhoardViewer.js
I found thatgetMonitoringDashboardId
,getMonitoringVPCConnectionId
, +updateSSMParameter
all will throw exceptions since trying to assume pivotRole in the dataall infra account before fetching/updating an SSM Param- Should we fix in this PR? If not this PR lets open a new one with a fix
Thanks @noah-paige, I will remove (1) and fix (2) in a separate PR. This one is getting out of hands :) |
@noah-paige Done! I removed the unused getPlatformAuthorSession |
Feature or Bugfix
Detail
get_pivot_role
,get_external_id
,get_pivot_role_template
Testing:
get_pivot_role
,get_external_id
,get_pivot_role_template
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A
. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
eval
or similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.