Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Notebook Naming Convention Pattern #237

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Add Notebook Naming Convention Pattern #237

merged 3 commits into from
Dec 6, 2022

Conversation

noah-paige
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Add notebook naming convention pattern to build a compliant name matching regex pattern required for SageMaker Notebook Instance

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dlpzx
dlpzx approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@dlpzx dlpzx merged commit 43528e9 into main Dec 6, 2022
@dlpzx dlpzx linked an issue Dec 7, 2022 that may be closed by this pull request
Notebook creation failure if name not in regex pattern #177
Closed
@dlpzx dlpzx mentioned this pull request Dec 7, 2022
Closed
@dlpzx dlpzx deleted the 177-notebook-name-regex-pattern branch January 31, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlpzx dlpzx dlpzx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notebook creation failure if name not in regex pattern
2 participants
@noah-paige @dlpzx