Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dev docker images base #387

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix: dev docker images base #387

merged 1 commit into from
Mar 28, 2023

Conversation

AmrSaber
Copy link
Contributor

Feature or Bug-fix

  • Bug-fix

Detail

The latest version of dev docker images for FE and BE no-longer has amazon-linux-extras, this update changes the based of the docker image to use tag 2 (which is consistent with the rest of the images) instead of latest (which is a bad practice anyway -- see 2.4 here)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you!

@dlpzx dlpzx merged commit f677371 into main Mar 28, 2023
@AmrSaber AmrSaber deleted the fix/docker-images branch March 28, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants