388 race condition occurs when adding folder to shared items in shares and errors out #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpodsh
reviewed
Mar 30, 2023
| @@ -196,7 +196,11 @@ def manage_access_point_and_policy(self): | |||
| ) | |||
| access_point_arn = S3.create_bucket_access_point(self.source_account_id, self.source_environment.region, self.bucket_name, self.access_point_name) | |||
| # Access point creation is slow | |||
| time.sleep(5) | |||
| while not S3.get_bucket_access_point_arn(self.source_account_id, self.source_environment.region, self.access_point_name): | |||
There was a problem hiding this comment.
We potentially can stuck here forever if there is an error and we can't create a access point. Should we think about task execution limit?
There was a problem hiding this comment.
Yeeep, I always overlook while loops! Thank you
nikpodsh
reviewed
Mar 30, 2023
| logger.info( | ||
| 'Waiting 30s for access point creation to complete..' | ||
| ) | ||
| time.sleep(30) | ||
| existing_policy = S3.get_access_point_policy(self.source_account_id, self.source_environment.region, self.access_point_name) |
There was a problem hiding this comment.
Not to request information twice we could do:
access_point_arn = S3.create_bucket_access_point(self.source_account_id, self.source_environment.region, self.bucket_name, self.access_point_name)
existing_policy = None
num_retries = ...
while not existing_policy and num_retries > 0:
num_retries -= 1
waiting....
existing_policy = S3.get_access_point_policy....
There was a problem hiding this comment.
The policy should not exist even after we create the access point. So checking the policy existence is not going to solve the issue. The error arises when we try to attach a new policy to a still-creating access point. But open to ideas on how to make it better, I coded it a bit fast
There was a problem hiding this comment.
Thanks for the clarification!
nikpodsh
approved these changes
Mar 30, 2023
dlpzx
deleted the
388-race-condition-occurs-when-adding-folder-to-shared-items-in-shares-and-errors-out
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.