frontend: make styling consistent and remove dead code #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmrSaber
changed the title
nikpodsh
reviewed
Mar 30, 2023
| {`Pending items: ${share.statistics.pendingItems}`} | ||
| </Typography> | ||
| </Box> | ||
| <Box |
There was a problem hiding this comment.
This code is identical to frontend/src/views/Shares/ShareInboxListItem.js. Let's extract it into dedicated form
There was a problem hiding this comment.
Refactoring and moving parts around will come in the subsequent PRs, I want this PR to be free from any logic so that it's easy to review and can be merged quickly. But I noted the comment and will apply it when working on the refactoring.
nikpodsh
reviewed
Mar 30, 2023
nikpodsh
reviewed
Mar 30, 2023
nikpodsh
approved these changes
Mar 30, 2023
dlpzx
approved these changes
Apr 5, 2023
dlpzx
pushed a commit
that referenced
this pull request
Apr 11, 2023
### Feature or Bug-fix - Refactoring ### Detail My recent PR #394 has a lot of changes but all of these changes are to styles only and not the code itself, this way the blame history for all the changed files is lost (it will always blame me). This PR adds the file`.git-blame-ignore-revs` which contains the id of the styling commit and the command that you need to run once to fix the blame history for you. Also Github understands that file and will show the history correctly. This PR is based on [this article](https://www.stefanjudis.com/today-i-learned/how-to-exclude-commits-from-git-blame/) and is suggested by Raul. This file works for the whole repository, and in the future one only needs to add ids of styling commits and the history will be preserved correctly. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
dlpzx
pushed a commit
to dlpzx/aws-dataall
that referenced
this pull request
May 25, 2023
) ### Feature or Bug-fix - Refactoring ### Details This PR does 2 things: - Makes the styling consistent across the project - Removes dead code (unused variables, functions, and imports) --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
dlpzx
pushed a commit
to dlpzx/aws-dataall
that referenced
this pull request
May 25, 2023
### Feature or Bug-fix - Refactoring ### Detail My recent PR data-dot-all#394 has a lot of changes but all of these changes are to styles only and not the code itself, this way the blame history for all the changed files is lost (it will always blame me). This PR adds the file`.git-blame-ignore-revs` which contains the id of the styling commit and the command that you need to run once to fix the blame history for you. Also Github understands that file and will show the history correctly. This PR is based on [this article](https://www.stefanjudis.com/today-i-learned/how-to-exclude-commits-from-git-blame/) and is suggested by Raul. This file works for the whole repository, and in the future one only needs to add ids of styling commits and the history will be preserved correctly. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bug-fix
Details
This PR does 2 things:
This is done through eslint rules, I noticed that the project has prettier rules and uses prettier, but the rules were not in sync with eslint and were not enforced, so the styling was in consistent. So for this matter I configured eslint to enforce prettier rules so that the styling is consistent. And that's what the first commit does, there are no code changes what so ever in it, just styling updates.
For the second commit, I removed all unused variables, functions, and imports, there is also no logic changes, only removing the unused parts.
The third commit removes
==in favour of===as this may cause some unintentional bugs (see this stackoverflow question).The last commit is the actual configuration enforcing all the rules -- this commit is at the end not the beginning because the configuration kept changing until I reached the final state, and I didn't want to pollute the PR with a lot of configuration commits.
As stated, the PR's commits are meaningful and I recommend reviewing the PR by going through each commit individually
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.