Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solve deployment bug #433 CloudFront logs does not enable ACL access #437

Merged
merged 1 commit into from
May 5, 2023
Merged

fix: solve deployment bug #433 CloudFront logs does not enable ACL access #437

merged 1 commit into from
May 5, 2023

Conversation

akaitoua
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

Solved bug 433, starting from April 2023 S3 default configurations changed, the default for s3 is set to disable ACL. Which is giving an issue for cloudfront logging on s3. The solution was to change the ownership of the object to object writer (enabling ACL for object writer as stated in cloudfront documentation).

Relates

-

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@nikpodsh nikpodsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@akaitoua akaitoua closed this May 4, 2023
@akaitoua akaitoua reopened this May 4, 2023
@akaitoua
Copy link
Contributor Author

akaitoua commented May 4, 2023

@nikpodsh @dlpzx would you merge this ?

@nikpodsh nikpodsh merged commit 2a319ca into data-dot-all:main May 5, 2023
@nikpodsh
Copy link
Contributor

nikpodsh commented May 5, 2023

Merged!

@dlpzx
Copy link
Contributor

dlpzx commented May 8, 2023

@akaitoua thank you so much for fixing this issue!

@dlpzx dlpzx changed the title solve deployment bug #433 CloudFront logs does not enable ACL access fix: solve deployment bug #433 CloudFront logs does not enable ACL access May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants