feat: Modify docker-compose yaml to read region and default region from env… #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpodsh
reviewed
May 9, 2023
docker-compose.yaml
Outdated
| @@ -16,7 +16,8 @@ services: | |||
| - db | |||
| environment: | |||
| envname: 'dkrcompose' | |||
| AWS_DEFAULT_REGION: "eu-west-1" | |||
| AWS_REGION: "${AWS_REGION}" | |||
There was a problem hiding this comment.
We could consider specify the default values if the env variables are not specify. e.g.:
AWS_REGION: "${AWS_REGION:-eu-west-1}"
AWS_DEFAULT_REGION: "${AWS_DEFAULT_REGION:-eu-west-1}"
Otherwise, we have to provide them all the time from the console
There was a problem hiding this comment.
I agree, as it is it already defaults to Ireland in the backend code, but I think it is better to set the region default earlier, not in the last piece of the workflow. Added in the last commit
|
@nikpodsh yesterday GitHub faced some issues with their APIs and I had some issues commiting your suggestion. But it is there now |
nikpodsh
approved these changes
May 10, 2023
dlpzx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Added
AWS_REGIONto the environment variables of the Docker containers for local development. Set bothAWS_DEFAULT_REGIONandAWS_REGIONto their values set on the terminal wheredocker-compose upis run.If these values are not set,
eu-west-1is used as defaultAnother PR with better instructions to the github pages documentation (deploy locally) will follow.
Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.