Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade aurora engine version to 11.16 #471

Merged
merged 2 commits into from
May 24, 2023

Conversation

kimengu-david
Copy link
Contributor

@kimengu-david kimengu-david commented May 23, 2023

Feature or Bugfix

  • Bugfix

Detail

Update Aurora engine version to 11.16. Fixes an issue where the Aurora nested stack deployment in the data.all backend which goes to deployment account would fail as AuroraPostgresEngineVersion.VER_10_18 is not compatible with parameter group default.aurora-postgresql11

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx changed the title Upgrade aurora engine version to 11.15 fix: Upgrade aurora engine version to 11.15 May 23, 2023
@dlpzx
Copy link
Contributor

dlpzx commented May 23, 2023

Hi @kimengu-david thanks for opening the PR! I tested the upgrade to 11.15 on a pre-existing deployment and it failed with the following:
image

Which is a little strange given that the documentation states that we can upgrade from 10.18 to 11.15. In any case, I tested upgrading to 11.16 and it worked fine, but I think that we still need to understand this behavior a little better.

I have a deployment of data.all V1.4 deployed a couple of months ago that has never been updated. RDS automatically performed the upgrade from engine 10.18 to 11.16 on May 15th. The same has happened with other deployments that initially set the engine version to 10.18.

In conclusion, my guess is that the PR #466 solved a particular issue in which the upgrade must have gotten stuck. We can either:

  • revert the changes in that PR and deploy with engine in major version 10 - if deployments are automatically upgraded to version 11 there must be a good reason, so staying in version 10 does not seem like the best idea
  • upgrade to major version 11 (using 11.16) - we need to be careful to not get into backwards compatibility issues as the one in the screenshot

What are your thoughts?

Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to ver_11_16

@kimengu-david
Copy link
Contributor Author

I would also go for the second option. Okay updating that now.

@kimengu-david kimengu-david changed the title fix: Upgrade aurora engine version to 11.15 fix: Upgrade aurora engine version to 11.16 May 24, 2023
@dlpzx dlpzx merged commit 3340610 into data-dot-all:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants