hotfix: Remove GitHub template option from data.all Pipelines #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpzx
changed the title
NickCorbett
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Remove the GitHub template development strategy from the possible types of data.all pipelines.
The initial idea was to use the parameter
--templatefrom the AWS DDK CLI which has been deprecated after its last major release (1.0.0). Using templates would enable customers to use any cookiecutter template directly in data.all.However, from the way that it was implemented it exposed a vulnerability in which customers could enter code instead of a template and perform cmd code injections in data.all ECS deployment task.
Given that this is a high-risk issue + AWS DDK 1.0.0 does not use CLI +
templatesare not critical for any known customer we will remove it for the moment to ensure security. In the future we will revisit other ways of providing templates and accelerating data pipeline building in a secure manner.Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.