Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit dataset role permissions #497

Merged
merged 13 commits into from
Jun 9, 2023

Commits on May 26, 2023

  1. fix: Fix typo that destroys storage locations (#481)

    ### Feature or Bugfix
    - Bugfix
    
    ### Detail
    The constant to define the dataallPivotRole missed an "a" and as a
    consequence the storage location for the Dataset was not registered
    
    ### Relates
    
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache 2.0 license.
    dlpzx authored May 26, 2023
    Configuration menu
    Copy the full SHA
    e9c64d7 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Update CDK Version to v2.77.0 to fix issue with CDK Pipeline role (#484)

    ### Feature or Bugfix
    - Bugfix
    - Refactoring
    
    ### Detail
    - The AWS Cloud Development Kit (CDK) Team recently identified an issue
    with the CDK Pipelines construct library that may result in unintended
    permissions being granted to authenticated users within your account. As
    of April 4, 2023, we have fixed the issue in version 1.200.0 [1] for CDK
    v1, and version 2.77.0 [2] for CDK v2. We strongly recommend you upgrade
    to one of these versions as soon as possible. Please refer to the
    Managing Dependencies documentation [3] in the CDK Developer Guide for
    instructions on how to perform the upgrade.
    Starting with versions 1.158.0 and 2.26.0, released May 30, 2022, the
    library creates a role that allows every identity in the same account
    with sts:AssumeRole permissions on Resource: * to assume it. This may
    result in granting privileges to authenticated users in your account
    allowing them to take pipeline actions beyond what was intended.
    
    ### Relates
    - N.A
    
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache 2.0 license.
    gmuslia authored May 30, 2023
    Configuration menu
    Copy the full SHA
    9fc84bf View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Configuration menu
    Copy the full SHA
    7844c1f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ece706 View commit details
    Browse the repository at this point in the history
  3. fix: safe removal of consumption roles with open share requests (#485)

    ### Feature or Bugfix
    - Bugfix
    
    ### Detail
    - Added check and exception if there are open share requests on a
    consumption role or on a group that we are removing from an environment
    
    ### Relates
    - #450 
    
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache 2.0 license.
    dlpzx authored Jun 1, 2023
    Configuration menu
    Copy the full SHA
    fa45abd View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Configuration menu
    Copy the full SHA
    02f6cde View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/feature/limit-dataset-role-permi…

    …ssions' into feature/limit-dataset-role-permissions
    
    # Conflicts:
    #	backend/dataall/cdkproxy/stacks/dataset.py
    dlpzx committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    7330e20 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2d61bea View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Finish restriction for users in dataset roles + enforced crawler + ch…

    …anges in read environment bucket - missing:errors on profiling jobs and KMS key of environment bucket
    dlpzx committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    36e8e33 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4117f94 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d8b067f View commit details
    Browse the repository at this point in the history
  4. Linting

    dlpzx committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    2c5d361 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Configuration menu
    Copy the full SHA
    bbd0fcc View commit details
    Browse the repository at this point in the history