Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add share reason in share requests #498

Merged
merged 24 commits into from
Jun 22, 2023
Merged

feat: add share reason in share requests #498

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ba50610
Add Share Request Reason and Reject Reason
noah-paige Jun 5, 2023
fce6d68
Tweaks Reject Share Object Modal
noah-paige Jun 6, 2023
8955c1d
linting
noah-paige Jun 6, 2023
9eca7ff
linting
noah-paige Jun 6, 2023
1eed926
Unit Tests
noah-paige Jun 6, 2023
c92af38
unit test
noah-paige Jun 6, 2023
df794b3
Add String Limit Reject Share
noah-paige Jun 7, 2023
ba76e79
Remove commented out code
noah-paige Jun 7, 2023
236568d
Add Edit ability of Share request and reject purpose depending on use…
noah-paige Jun 8, 2023
72b6960
lint
noah-paige Jun 8, 2023
42aa8bc
Add unit tests and fix string limits
noah-paige Jun 9, 2023
bb4a618
Finish unit tests
noah-paige Jun 9, 2023
826dbc5
Clear reject purpose on approve
noah-paige Jun 12, 2023
4f07c26
Fix typo and edit frontend view for share comments
noah-paige Jun 13, 2023
6ff5017
Update Share Object Permissions for SUBMIT_SHARE_OBJECT
noah-paige Jun 14, 2023
7302fb6
Transfer Stewardship
noah-paige Jun 15, 2023
cfabeb4
Remove commented out code
noah-paige Jun 15, 2023
542bd6e
Dataset Admins get Approver Share Object Status
noah-paige Jun 15, 2023
2066f90
linting
noah-paige Jun 15, 2023
76e92ad
clean up commented out code in conftest
noah-paige Jun 21, 2023
6d339d2
Wrap Lines for Reject Request Purposes
noah-paige Jun 21, 2023
0f44b18
Fix resolve_user_role() for consumption roles
noah-paige Jun 21, 2023
e77015b
Add Downgrade Share Object Permissions Revert
noah-paige Jun 21, 2023
8ddd6dd
Testing Downgrade Fix
noah-paige Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frontend/src/views/Shares/ShareView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,6 +739,7 @@ const ShareView = () => {
<Typography
color="textPrimary"
variant="subtitle2"
sx={{ wordBreak: "break-word" }}
>
{share.requestPurpose || '-'}
</Typography>
Expand All @@ -764,6 +765,7 @@ const ShareView = () => {
<Typography
color="textPrimary"
variant="subtitle2"
sx={{ wordBreak: "break-word" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

>
{share.rejectPurpose || '-'}
</Typography>
Expand Down