Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Glue Resource Policy Permissions for cross account share requests #579

Merged
merged 1 commit into from
Jul 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion backend/dataall/cdkproxy/stacks/pivot_role.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def _create_dataall_policy0(self, env_resource_prefix: str) -> iam.ManagedPolicy
],
resources=[f'arn:aws:s3:*:{self.account}:accesspoint/*'],
),
# Glue - needed to handle databases and tables
# Glue - needed to handle databases and tables and cross-account shares
iam.PolicyStatement(
sid='GlueCatalog',
effect=iam.Effect.ALLOW,
Expand All @@ -193,6 +193,8 @@ def _create_dataall_policy0(self, env_resource_prefix: str) -> iam.ManagedPolicy
'glue:UpdatePartition',
'glue:UpdateTable',
'glue:TagResource',
'glue:DeleteResourcePolicy',
'glue:PutResourcePolicy',
],
resources=['*'],
),
Expand Down
2 changes: 2 additions & 0 deletions deploy/pivot_role/pivotRole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ Resources:
- 'glue:UpdatePartition'
- 'glue:UpdateTable'
- 'glue:TagResource'
- 'glue:DeleteResourcePolicy'
- 'glue:PutResourcePolicy'
Effect: Allow
Resource: '*'
- Sid: GlueETL
Expand Down