Fix cloudfront stack in case custom domain is given #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeig-space
approved these changes
Aug 2, 2023
dbalintx
added a commit
to dbalintx/aws-dataall
that referenced
this pull request
Aug 3, 2023
### Feature or Bugfix - Bugfix ### Detail In case a custom domain and ACM certificate is configured for CloudFront, these parameters have to be passed differently to the newly introduced CloudFront distribution CDK class, introduced in [v1.6](data-dot-all@84c555e#diff-c65de5ab1eebd2a930807381430fa602793cc9966ab2a064cb29603162377030) ### Relates data-dot-all#603 Testing: Tested by, - creating a fresh deployment with v1.5 with a custom domain and SSL certificate - upgrading to v1.6, with the bugfix content from this PR 2 issues that are detailed in data-dot-all#603 arose (both related to the upgrade process), mitigation method of them is detailed there in the issue. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
In case a custom domain and ACM certificate is configured for CloudFront, these parameters have to be passed differently to the newly introduced CloudFront distribution CDK class, introduced in v1.6
Relates
#603
Testing:
Tested by,
2 issues that are detailed in #603 arose (both related to the upgrade process), mitigation method of them is detailed there in the issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.