Move custom resources to Dataset Environment extension #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpodsh
reviewed
Aug 11, 2023
| # Set PivotRole as Lake Formation data lake admin | ||
| entry_point = str( | ||
| pathlib.PosixPath(os.path.dirname(__file__), | ||
| './assets/lakeformationdefaultsettings').resolve() |
There was a problem hiding this comment.
In DatasetGlueProfilerExtension, the relative path is different. We need to check which one is correct
There was a problem hiding this comment.
I tested the creation of the Dataset with the extensions and it worked fine with this paths. At first I had the same level for both but i think because of the libraries we use they are defined differently
|
I have only one question. The rest changes look good to me! |
nikpodsh
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Datasetmodulesse-s3for created datasets, while it should be the bucketNameRelates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.