Fix migration script for v1.2 upgrade #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louishourcade
approved these changes
Aug 11, 2023
nikpodsh
reviewed
Aug 11, 2023
|
|
||
| def upgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| # Modify column types | ||
| print("Upgrade devStages and devStrategy column types. Updating nullable to True...") | ||
| op.add_column( | ||
| 'datapipeline', | ||
| sa.Column('template', sa.String(), nullable=True) | ||
| ) |
There was a problem hiding this comment.
Why do we declare nullable=True for devStrategy and devStages if both columns are originally nullable?
There was a problem hiding this comment.
The important part of this stage is to update the existing_type
nikpodsh
approved these changes
Aug 14, 2023
nikpodsh
added a commit
that referenced
this pull request
Aug 16, 2023
Merge latest changes from main into modularization-main It includes changes from #626, #630, #648, #649, and #651 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dlpzx <71252798+dlpzx@users.noreply.github.com> Co-authored-by: wolanlu <101870655+wolanlu@users.noreply.github.com> Co-authored-by: Amr Saber <amr.m.saber.mail@gmail.com> Co-authored-by: Noah Paige <69586985+noah-paige@users.noreply.github.com> Co-authored-by: kukushking <kukushkin.anton@gmail.com> Co-authored-by: Dariusz Osiennik <osiend@amazon.com> Co-authored-by: Dennis Goldner <107395339+degoldner@users.noreply.github.com> Co-authored-by: Abdulrahman Kaitoua <abdulrahman.kaitoua@polimi.it> Co-authored-by: akaitoua-sa <126820454+akaitoua-sa@users.noreply.github.com> Co-authored-by: Gezim Musliaj <102723839+gmuslia@users.noreply.github.com> Co-authored-by: Rick Bernotas <97474536+rbernotas@users.noreply.github.com> Co-authored-by: David Mutune Kimengu <57294718+kimengu-david@users.noreply.github.com> Co-authored-by: chamcca <40579012+chamcca@users.noreply.github.com> Co-authored-by: Dhruba <117375130+marjet26@users.noreply.github.com> Co-authored-by: dbalintx <132444646+dbalintx@users.noreply.github.com> Co-authored-by: Srinivas Reddy <srinivasreddych@outlook.com> Co-authored-by: mourya-33 <134511711+mourya-33@users.noreply.github.com> Co-authored-by: Noah Paige <noahpaig@amazon.com> Co-authored-by: dlpzx <dlpzx@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
devStrategyanddevStagesvalues were not backfilled which causes nulls in the RDS table that are not allowed as this column should contain only non-null values.In this PR we modify that script for customers that have not updated yet. It is not 100% clear to me whether we should merge it, but I wanted to raise awareness of this issue here.
Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.