Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor db names #677

Merged
merged 32 commits into from
Aug 18, 2023
Merged

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Aug 18, 2023

Feature or Bugfix

  • Refactoring

Detail

Make naming inside the db package consistent. Always use -models or repositories suffix.

Relates

  • 2.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nikpodsh and others added 29 commits August 8, 2023 15:52
Created a way to run dependencies for modules
Removed duplication in tests
# Conflicts:
#	tests/modules/worksheets/test_worksheet_feed.py
…ctor-and-modularize-tests

# Conflicts:
#	tests/api/conftest.py
#	tests/conftest.py
#	tests/modules/catalog/test_glossary.py
#	tests/modules/datasets/test_dataset_glossary.py
#	tests/modules/datasets/test_dataset_indexers.py
#	tests/modules/datasets/test_environment_stack_with_dataset.py
# Conflicts:
#	tests/conftest.py
#	tests/core/conftest.py
#	tests/core/environments/test_environment.py
#	tests/core/permissions/test_permission.py
#	tests/core/stacks/test_keyvaluetag.py
#	tests/core/vpc/test_vpc.py
#	tests/modules/conftest.py
#	tests/modules/datapipelines/test_pipeline_stack.py
#	tests/modules/datasets/conftest.py
#	tests/modules/datasets/tasks/test_dataset_catalog_indexer.py
#	tests/modules/datasets/tasks/test_dataset_policies.py
#	tests/modules/datasets/tasks/test_dataset_subscriptions.py
#	tests/modules/datasets/tasks/test_dataset_tables_sync.py
#	tests/modules/datasets/tasks/test_stacks_updater_with_datasets.py
#	tests/modules/datasets/test_dataset.py
#	tests/modules/datasets/test_dataset_glossary.py
#	tests/modules/datasets/test_dataset_location.py
#	tests/modules/datasets/test_dataset_permissions.py
#	tests/modules/datasets/test_dataset_profiling.py
#	tests/modules/datasets/test_dataset_resource_found.py
#	tests/modules/datasets/test_dataset_stack.py
#	tests/modules/datasets/test_environment_stack_with_dataset.py
#	tests/modules/feed/testhelper.py
#	tests/modules/mlstudio/cdk/conftest.py
#	tests/modules/mlstudio/conftest.py
#	tests/modules/notebooks/cdk/conftest.py
#	tests/modules/notebooks/conftest.py
@dlpzx dlpzx requested a review from nikpodsh August 18, 2023 08:16
Copy link
Contributor

@nikpodsh nikpodsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @dlpzx, thanks for taking care of it 🚀

dlpzx added 2 commits August 18, 2023 12:55
# Conflicts:
#	backend/dataall/modules/dashboards/__init__.py
#	backend/dataall/modules/datasets/__init__.py
#	backend/dataall/modules/datasets/services/dataset_service.py
@dlpzx dlpzx merged commit f780e3b into data-dot-all:modularization-main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants