Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DA v2: Fix Get Query on Chat/Feed Feature #729

Merged
merged 5 commits into from
Sep 6, 2023
Merged

DA v2: Fix Get Query on Chat/Feed Feature #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7770751
Remove typename and label from get feed messages query
noah-paige Sep 5, 2023
05d448d
Clean Feed return type
noah-paige Sep 5, 2023
3ba69a2
Revert "Remove typename and label from get feed messages query"
noah-paige Sep 5, 2023
177a9af
Revert local dev changes
noah-paige Sep 5, 2023
3ce3dbb
Revert local dev changes
noah-paige Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions backend/dataall/modules/feed/api/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from dataall.base.api import gql
from dataall.modules.feed.api.resolvers import resolve_feed_target_type, resolve_messages, resolve_target
from dataall.modules.feed.api.resolvers import resolve_feed_target_type, resolve_messages
from dataall.modules.feed.api.registry import FeedRegistry


Expand All @@ -14,7 +14,6 @@
fields=[
gql.Field(name='feedTargetUri', type=gql.NonNullableType(gql.String)),
gql.Field(name='feedTargetType', type=gql.NonNullableType(gql.String)),
gql.Field(name='target', resolver=resolve_target, type=gql.Ref('FeedTarget')),
gql.Field(
name='messages',
args=[gql.Argument(name='filter', type=gql.Ref('FeedMessageFilter'))],
Expand Down
18 changes: 0 additions & 18 deletions frontend/src/services/graphql/Feed/listFeedMessages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,6 @@ export const listFeedMessages = ({ targetUri, targetType, filter }) => ({
$filter: FeedMessageFilter
) {
getFeed(targetUri: $targetUri, targetType: $targetType) {
target {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we will have the same issue for listGlossaryAssociations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine so when one of dashboard or dataset are disabled - is this something that will be resolved as part of PR #731? Otherwise I can open a separate PR once I validate that error as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noah-paige I was not going to include it in the PR as it is already quite packed. Can we wait for #731 to be merged and then fix the feed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good - let's do that and I will merge this PR

__typename
... on DatasetTable {
label
}
... on Dataset {
label
}
... on DatasetStorageLocation {
label
}
... on Dashboard {
label
}
... on DataPipeline {
label
}
}
messages(filter: $filter) {
count
hasNext
Expand Down
Loading