Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolutions for yarn.lock pinned packages #757

Merged
merged 2 commits into from
Sep 14, 2023
Merged

resolutions for yarn.lock pinned packages #757

merged 2 commits into from
Sep 14, 2023

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Sep 14, 2023

Feature or Bugfix

  • Bugfix

Detail

yarn.lock and package-lock.json react differently when defining specific versions for a package in package.json

  • yarn.lock works when the pinned packages are added to the resolutions section
  • package-lock.json when they are in the overrides section

When generating each of these accommodate the package.json accordingly.

Relates

Dependabot and npm audit

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this in an AWS Deployment - frontend built properly and all looks good

Approving!

@dlpzx dlpzx merged commit 4f742cf into main Sep 14, 2023
8 checks passed
@dlpzx dlpzx deleted the fix/dependabot-new branch November 8, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants