Feat: Move notifications from core to modules to facilitate customization #790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
As a rule of thumb, we encourage customization of
modules
while changes incore
should be avoided when possible.notifications
is a component initially in core which is only used bydataset_sharing
. To facilitate customization of thenotifications
module and also to clearly see its dependencies we have:notifications
code from core to modules as it is a reusable component that is not needed by any core component.notifications
independent from any other moduleTODO:
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A
. Based onOWASP 10.
N/A
just refactoringBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.