Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/sagemakerdomain #82

Merged
merged 9 commits into from
Aug 2, 2022
Merged

Feat/sagemakerdomain #82

merged 9 commits into from
Aug 2, 2022

Conversation

JahedZ
Copy link
Contributor

@JahedZ JahedZ commented Jul 11, 2022

Feature or Bugfix

  • Feature

Detail

  • In this PR, we provide the code to deploy a Sagemaker Domain with basic settings upon creation of a data.all workspace
  • We also extend the Sagemaker permissions available to users, while ensuring they can only access their team's resources (using a resource tagging strategy)
  • This takes as an input your default VPC, and assumes it has the appropriate networking configurations. To learn about the network requirements for Sagemaker Studio, read this documentation https://docs.aws.amazon.com/sagemaker/latest/dg/studio-notebooks-and-internet-access.html. For advanced networking customizations, stacks/environment.py should be modified according to your ecosystem's needs.

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@JahedZ JahedZ mentioned this pull request Jul 11, 2022
Closed
@dlpzx dlpzx self-requested a review July 12, 2022 07:37
@dlpzx dlpzx added the type: bug Something isn't working label Jul 12, 2022
@dlpzx dlpzx added this to the v0.1.0 milestone Jul 12, 2022
dosiennik
dosiennik reviewed Jul 18, 2022
View reviewed changes
backend/dataall/cdkproxy/stacks/environment.py Outdated
default_vpc = ec2.Vpc.from_lookup(self, 'VPCStudio', is_default=True)
vpc_id = default_vpc.vpc_id
subnet_ids = [private_subnet.subnet_id for private_subnet in default_vpc.private_subnets]
subnet_ids += [public_subnet.subnet_id for public_subnet in default_vpc.public_subnets]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we support isolated subnets too? In our case we have our own VPC setup with isolated subnets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added a corresponding commit

@JahedZ JahedZ requested a review from dlpzx July 22, 2022 14:47
@degoldner
Copy link
Contributor

Any update on this issue?

@dlpzx dlpzx merged commit 6b17d2a into data-dot-all:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosiennik dosiennik dosiennik left review comments

@dlpzx dlpzx Awaiting requested review from dlpzx

Assignees

@JahedZ JahedZ

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JahedZ @degoldner @dosiennik @dlpzx