Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move feature toggle checker to base #833

Merged

Conversation

dbalintx
Copy link
Contributor

@dbalintx dbalintx commented Oct 26, 2023

Feature or Bugfix

Detail

Move feature toggle checker to base folder

Relates

Move feature toggle to base

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10. N/A

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx
Copy link
Contributor

dlpzx commented Oct 27, 2023

@dbalintx thanks for the PR! We will wait for after the release of V2.1 to merge it. With v2.1 there might be some things that will need to be adjusted. We will let you know :)

@anmolsgandhi anmolsgandhi added this to the v2.2.0 milestone Nov 7, 2023
Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dbalintx, I have reviewed the code after changes in v2.1. There was one missing import but it is fixed now

Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this PR as well and tested in AWS with all of our module/core features disabled - all is working as expected think this is good to merge!

@dlpzx dlpzx merged commit 2a44e8e into data-dot-all:main Nov 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants