Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #838

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Update CONTRIBUTING.md #838

merged 1 commit into from
Oct 31, 2023

Conversation

NickCorbett
Copy link
Contributor

/vote

Feature or Bugfix

  • Refactoring

Detail

  • Removing the statement that says we might ask contributors to sign a Contributor Licence Agreement and replacing with a simple statement that says all contributions will be made in accordance with the LICENCE.txt file.

Relates

  • N/A

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)? N/A
    • Is the input sanitized? N/A
    • What precautions are you taking before deserializing the data you consume? N/A
    • Is injection prevented by parametrizing queries? N/A
    • Have you ensured no eval or similar functions are used? N/A
  • Does this PR introduce any functionality or component that requires authorization? N/A
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms? N/A
    • Are you logging failed auth attempts? N/A
  • Are you using or adding any cryptographic features? N/A
    • Do you use a standard proven implementations? N/A
    • Are the used keys controlled by the customer? Where are they stored? N/A
  • Are you introducing any new policies/roles/users? N/A
    • Have you used the least-privilege principle? How? N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Removing the statement that says we might ask contributors to sign a Contributor Licence Agreement and replacing with a simple statement that says all contributions will be made in accordance with the LICENCE.txt file.

/vote
@git-vote
Copy link

git-vote bot commented Oct 30, 2023

Vote created

@NickCorbett has called for a vote on Update CONTRIBUTING.md (#838).

The members of the following teams have binding votes:

Team
@awslabs/data-all-maintainers

Non-binding votes are also appreciated as a sign of support!

How to vote

You can cast your vote by reacting to this comment. The following reactions are supported:

In favor Against Abstain
👍 👎 👀

Please note that voting for multiple options is not allowed and those votes won't be counted.

The vote will be open for 7days. It will pass if at least 100% of the users with binding votes vote In favor 👍. Once it's closed, results will be published here as a new comment.

@git-vote
Copy link

git-vote bot commented Oct 31, 2023

Vote closed

The vote passed! 🎉

100.00% of the users with binding vote were in favor (passing threshold: 100%).

Summary

In favor Against Abstain Not voted
5 0 0 0

Binding votes (5)

User Vote Timestamp
@NickCorbett In favor 2023-10-30 9:42:06.0 +00:00:00
@anmolsgandhi In favor 2023-10-30 19:29:43.0 +00:00:00
@dlpzx In favor 2023-10-30 10:38:16.0 +00:00:00
@noah-paige In favor 2023-10-30 13:21:56.0 +00:00:00
@nikpodsh In favor 2023-10-30 11:54:01.0 +00:00:00

Non-binding votes (2)

User Vote Timestamp
@zsaltys In favor 2023-10-30 12:57:03.0 +00:00:00
@rbernotas In favor 2023-10-30 13:32:31.0 +00:00:00

Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No typos. First voting!

@NickCorbett NickCorbett merged commit df14146 into main Oct 31, 2023
9 checks passed
@NickCorbett NickCorbett deleted the NickCorbett-Remove-CLA branch October 31, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants