Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Disappearing Env Value Reqest Access Modal #919

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

noah-paige
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • When requesting access environment dropdown value sometimes disappears and becomes blank
    • Believed root cause is that environmentOptions needs to finish loading before the request access modal allows users to select an environment so that the selection does not disappear

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@noah-paige noah-paige marked this pull request as ready for review December 15, 2023 14:35
@noah-paige noah-paige added this to the v2.3.0 milestone Dec 15, 2023
@dlpzx
Copy link
Contributor

dlpzx commented Dec 18, 2023

Looks good, I will test and then approve

@dlpzx
Copy link
Contributor

dlpzx commented Dec 19, 2023

Tested in AWS:

  • CICD passes successfully
  • Open share request and environment field does not dissapear

@noah-paige noah-paige merged commit bda24a3 into main Dec 20, 2023
8 checks passed
@dlpzx dlpzx deleted the fix/disappearing-env-value branch January 10, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When requesting access environment dropdown value sometimes disappears
2 participants