Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing s3 bucket sharing for federated roles #920

Merged
merged 2 commits into from
Dec 18, 2023
Merged

fixing s3 bucket sharing for federated roles #920

merged 2 commits into from
Dec 18, 2023

Conversation

zsaltys
Copy link
Contributor

@zsaltys zsaltys commented Dec 15, 2023 •
edited
Loading

Feature or Bugfix

  • Bugfix

Detail

  • Creating share requests for S3 buckets with roles like arn:aws:iam::1234:role/sso/foo will fail the share because /sso/ will be removed by backend resulting in an exception with an invalid principal. This was fixed before for access points etc but was missed in S3 bucket sharing.

Relates

Security

N/A

@noah-paige noah-paige self-assigned this Dec 15, 2023
@noah-paige noah-paige added this to the v2.3.0 milestone Dec 18, 2023
@noah-paige noah-paige linked an issue Dec 18, 2023 that may be closed by this pull request
Share requests fail for S3 buckets with federated roles #921
Closed
@noah-paige
Copy link
Contributor

Tested these changes in AWS Deployment with a service role as share principal:

  • CICD Pipeline successful + Quality Gate Passes
  • Folder Share Successful
  • Bucket Share Successful
  • Folder Share Revoke Successful
  • Bucket Share Revoke Successful

noah-paige
noah-paige approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in AWS - lgtm, approving!

@noah-paige noah-paige merged commit 41a4cb9 into data-dot-all:main Dec 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noah-paige noah-paige noah-paige approved these changes

Assignees

@noah-paige noah-paige

Labels
None yet
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

Share requests fail for S3 buckets with federated roles
2 participants
@zsaltys @noah-paige