Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added KMS encryption for Aurora DB secrets #935

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Added KMS encryption for Aurora DB secrets #935

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8394142
Added KMS encryption for secrets
Dec 20, 2023
20b2b40
Rename encryption key
dlpzx Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions deploy/stacks/aurora.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ def __init__(
super().__init__(scope, id, **kwargs)

# if exclude_characters property is set make sure that the pwd regex in DbConfig is changed accordingly
db_credentials = rds.DatabaseSecret(
self, f'{resource_prefix}-{envname}-aurora-db', username='dtaadmin'
)


db_subnet_group = rds.SubnetGroup(
self,
Expand Down Expand Up @@ -65,6 +63,10 @@ def __init__(
alias=f'{resource_prefix}-{envname}-aurora',
enable_key_rotation=True,
)

db_credentials = rds.DatabaseSecret(
self, f'{resource_prefix}-{envname}-aurora-db', username='dtaadmin', encryption_key=key
)

database = rds.ServerlessCluster(
self,
Expand Down
Loading