Fix when migrating from Manually Created Pivot Role to Auto Create Pivot Role

[TejasRGitHub]

Feature or Bugfix

• Bugfix

Detail

• Changes in the way KMS keys of datasets( S3 buckets ) are specified in the environment role .

Testing

• Created an environment with manual pivot role and migrated to auto create pivot role.
• Checked if the datasets previously present in the environment get updated properly.
• Imported another dataset on this environment successfully.

Relates

• https://ouryahoo.atlassian.net/browse/DATA-416

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

• Does this PR introduce or modify any input fields or queries - this includes
  fetching data from storage outside the application (e.g. a database, an S3 bucket)? N/A
  • Is the input sanitized?
  • What precautions are you taking before deserializing the data you consume?
  • Is injection prevented by parametrizing queries?
  • Have you ensured no eval or similar functions are used?
• Does this PR introduce any functionality or component that requires authorization? N/A
  • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  • Are you logging failed auth attempts?
• Are you using or adding any cryptographic features? N/A
  • Do you use a standard proven implementations?
  • Are the used keys controlled by the customer? Where are they stored?
• Are you introducing any new policies/roles/users? Yes
  • Have you used the least-privilege principle? How? Yes, only access to KMS keys which are present on the environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[TejasRGitHub]

Updating code to add imported section after checking if datasets are present

[dlpzx]

Testing in AWS. I took an existing environment with multiple datasets (some imported KMS keys) in a deployment using manual pivot role ---> updated the code with this PR and changed to auto created pivot role in the cdk.json to really re-create the fix.

• CICD completes without issue
• update environment by clicking manually "update " in the environment Stack tab. Update is triggered
• update creates pivot role
• update modifies environment role and adds the 1 "KMSImportedDatasetAccess" statement to the DataPolicy

Looks great, approving!

[dlpzx]

reviewed and tested