Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue 949: validate consumer roles #951

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

SofiaSazonova
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

Check if role ARN matches the role name (boto3 get_role works by name, not by arn)

Relates

#949

Security

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)? N/A
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?N/A
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?N/A
    • Are you logging failed auth attempts?N/A
  • Are you using or adding any cryptographic features?N/A
    • Do you use a standard proven implementations?N/A
    • Are the used keys controlled by the customer? Where are they stored?N/A
  • Are you introducing any new policies/roles/users?N/A
    • Have you used the least-privilege principle? How?N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check if role ARN matches the role name (boto3 get_role works by name, not by arn)
@noah-paige
Copy link
Contributor

Tested this PR in AWS Deployment, validated:

  • CICD Pipeline Succeeds
  • Add Consumption Role Fails - Wrong Role Name
  • Add Consumption Role Fails - Wrong Account ARN
  • Add Consumption Role Succeeds - Correct Role ARN
  • Remove Consumption Role Succeeds

Will wait until npm-audit check is fixed in separate PR before then approving and merging this one as well

@noah-paige
Copy link
Contributor

noah-paige commented Jan 10, 2024

@SofiaSazonova - could you merge latest OS to your branch? I can approve once confirm npm-audit check successful

@SofiaSazonova
Copy link
Contributor Author

Done

Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Approving

@dlpzx dlpzx merged commit b2c721c into data-dot-all:main Jan 10, 2024
8 checks passed
@SofiaSazonova SofiaSazonova deleted the issue-949 branch October 3, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumer roles should be validated that they exist
3 participants