Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] move streetView.tsx to widgets directory #439

Closed
yuvalbl opened this issue Oct 21, 2020 · 0 comments
Closed

[Refactor] move streetView.tsx to widgets directory #439

yuvalbl opened this issue Oct 21, 2020 · 0 comments
Assignees
@shaked-hayek
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yuvalbl
Copy link
Collaborator

yuvalbl commented Oct 21, 2020

streetView.tsx is a class component, not a service

Refactor Steps:

  1. Move file streetView.tsx from services to src/components/molecules/widgets
  2. Rename file from streetView.tsx to StreetViewAsyncLoader.tsx`
  3. Inside the file, change class name from ReactStreetview to StreetViewAsyncLoader
  4. make sure the app compile correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaked-hayek shaked-hayek

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yuvalbl @Moranzi @shaked-hayek