Making the info font bigger #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaked-hayek
requested changes
Jan 4, 2024
| @@ -1,9 +1,203 @@ | |||
| // import React, { FC, useState } from 'react'; | |||
| // import { Card, CardContent, Box } from '@material-ui/core'; | |||
There was a problem hiding this comment.
These comments shouldn't remain here
|
|
||
| const handleCardEditorOpen = (name:string) =>{ | ||
| const handleCardEditorOpen = (name: string) => { |
There was a problem hiding this comment.
All these space changes are things that happen automatically sometimes by VScode, but you usually don't want to push them because, even though they are good changes, are not related to the issue
| @@ -96,6 +292,13 @@ const AnyWayCard: FC<IProps> = ({ | |||
| const sizes = getSizes(variant, factor); | |||
|
|
|||
| const classes = useStyles(); | |||
|
|
|||
| const tooltipClasses = makeStyles(() => ({ | |||
| tooltip: { | |||
There was a problem hiding this comment.
there already a var of makeStyles in this file, it is called useStyles. you should use it instead of creating a new one. Try to copy the way it is already done, and talk to me if you need help
atalyaalon
deleted the
1020-bug-the-text-in-info-button-is-very-small
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I change the font size of the info button to 13px.
Let me know if the size seems right to you or need another adjustment