Adjust titles for 2 widgets #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atalyaalon
added a commit
that referenced
this pull request
Feb 21, 2024
* [Feat-885] Add selection for stack bar graphs (#935) * Added stacked bar widgets a checkbox option * Add option to choose colors when changing displayed bars * Changed any to proper type, make number of bar generic and add function createBarWidget * Fix bug of changed values when closing card editor * PR review changes * Remove redundent imports * add conditional label, refactor utils (#938) Co-authored-by: Daniel Shely <> * Update .env.staging (#947) * Add critical indication (#948) * Added image * Added critical icon based on field value * Added critical option to the filter panel * Added enum value * Had to increase width * Added local critical filter * Added field to model * add alt attrinbte on image tag (#951) * Update .env.staging (#952) * Make critical filter non local (#958) * sufficient condition * Use object for fetch args * Send params in object format * Make fields optional * don't use "any" type hint * Update News.tsx (#961) * Update news-flash-store.ts (#962) * Update News.tsx * Update thank-you-names.csv * transaction dialog box (#966) Co-authored-by: EyalIlan <eyalilan8@gmail.com> * [Feat-925] Add location approval feature (#969) * initial feature commit with icon and new field * Added icon choice and display * Move critical icon * Add location change button * Make critical icon transperent * replace critical.gif with svg * Window open pressing button, seperated newsFlash comp to new file * Added user info * Status icon and buttons * Added map choice (need to finish with saving data) * Saving location and qualificaion data * Added manual option for location qualification and added user change * Fix responsibilty issue between the two files * Split Search city to 2 files * Spacing and page look * Changed initialLocation to be a function, and improved onClose location window * Split radio buttons to seperate file * updated put function for news flash --------- Co-authored-by: Daniel Shely <> * Feature add transcrption 4 widgets 957 (#968) * transaction dialog box * show transaction icon only widgets that has transaction * add copy image to transaction box * add widget vision_10_30_90 (#972) * Feature widget vision zero 10 50 90 (#975) * add widget vision_10_30_90 * change widget 10_30_90 to 10_50_90 * change the location of the start command in package.json (#977) * change the location of the start command in package.json change the location of the start command after receive this error: /usr/local/bin/node: bad option: --openssl-legacy-provider * add npx browserslist@latest --update-db before start the docker * add logo (#979) * add natun square logo (#982) * add widget lower bar (#981) * update logo (#980) * Update Footer.tsx (#986) * add data-for-change (#988) * Delete src/assets/hasadna.png (#989) * Bug click twice to change news backround (#984) * add widget lower bar * fix news menu bar bug you need to click twice to make the news backround active * Add dev-to-prod auth server change (#950) * Spliting title and subtitle, making title bold (#995) * Change design in bar widgets (#996) * Remove margin from bottom of bar charts (#1001) * Add check for user authentication in NewsFlash (#990) (#1003) * Fix subtitle param in CardEditor (#1005) (#1006) * Remove padding from bottom of stack bars (#1008) (#1009) * Open new widgets to production (#1012) (#1013) * Remove accident_count_by_driver_type from prod (#1016) * Update cards.const.ts * Add title and subtitle to heatmap widget (#1015) * fix the text in info button (make bigger) (#1020) (#1024) Co-authored-by: Barak Yakter <byakter@gmail,com> * fix the text in info button (make bigger) (#1020) (#1026) Co-authored-by: Barak Yakter <byakter@gmail,com> * Fix location qualification api use (#1022) (#1023) * Update generalConst.ts (#1027) * Add n12 org logo (#1031) (#1032) * Adjust titles for 2 widgets (#1036) Co-authored-by: Barak Yakter <byakter@gmail,com> * [Feat-1031] Add different color themes (for N12) (#1034) * Add n12 org logo (#1031) * Add Color Themes - N12 theme --------- Co-authored-by: shaked-hayek <85109951+shaked-hayek@users.noreply.github.com> Co-authored-by: danielsh28 <danielshely1@gmail.com> Co-authored-by: carmelp16 <46032304+carmelp16@users.noreply.github.com> Co-authored-by: EyalIlan <55767736+EyalIlan@users.noreply.github.com> Co-authored-by: EyalIlan <eyalilan8@gmail.com> Co-authored-by: Shai2022 <106345640+Shai2022@users.noreply.github.com> Co-authored-by: BarVolunteering <58947331+BarVolunteering@users.noreply.github.com> Co-authored-by: byakter <109795934+byakter@users.noreply.github.com> Co-authored-by: Barak Yakter <byakter@gmail,com>
atalyaalon
added a commit
that referenced
this pull request
Feb 21, 2024
* [Feat-885] Add selection for stack bar graphs (#935) * Added stacked bar widgets a checkbox option * Add option to choose colors when changing displayed bars * Changed any to proper type, make number of bar generic and add function createBarWidget * Fix bug of changed values when closing card editor * PR review changes * Remove redundent imports * add conditional label, refactor utils (#938) Co-authored-by: Daniel Shely <> * Update .env.staging (#947) * Add critical indication (#948) * Added image * Added critical icon based on field value * Added critical option to the filter panel * Added enum value * Had to increase width * Added local critical filter * Added field to model * add alt attrinbte on image tag (#951) * Update .env.staging (#952) * Make critical filter non local (#958) * sufficient condition * Use object for fetch args * Send params in object format * Make fields optional * don't use "any" type hint * Update News.tsx (#961) * Update news-flash-store.ts (#962) * Update News.tsx * Update thank-you-names.csv * transaction dialog box (#966) Co-authored-by: EyalIlan <eyalilan8@gmail.com> * [Feat-925] Add location approval feature (#969) * initial feature commit with icon and new field * Added icon choice and display * Move critical icon * Add location change button * Make critical icon transperent * replace critical.gif with svg * Window open pressing button, seperated newsFlash comp to new file * Added user info * Status icon and buttons * Added map choice (need to finish with saving data) * Saving location and qualificaion data * Added manual option for location qualification and added user change * Fix responsibilty issue between the two files * Split Search city to 2 files * Spacing and page look * Changed initialLocation to be a function, and improved onClose location window * Split radio buttons to seperate file * updated put function for news flash --------- Co-authored-by: Daniel Shely <> * Feature add transcrption 4 widgets 957 (#968) * transaction dialog box * show transaction icon only widgets that has transaction * add copy image to transaction box * add widget vision_10_30_90 (#972) * Feature widget vision zero 10 50 90 (#975) * add widget vision_10_30_90 * change widget 10_30_90 to 10_50_90 * change the location of the start command in package.json (#977) * change the location of the start command in package.json change the location of the start command after receive this error: /usr/local/bin/node: bad option: --openssl-legacy-provider * add npx browserslist@latest --update-db before start the docker * add logo (#979) * add natun square logo (#982) * add widget lower bar (#981) * update logo (#980) * Update Footer.tsx (#986) * add data-for-change (#988) * Delete src/assets/hasadna.png (#989) * Bug click twice to change news backround (#984) * add widget lower bar * fix news menu bar bug you need to click twice to make the news backround active * Add dev-to-prod auth server change (#950) * Spliting title and subtitle, making title bold (#995) * Change design in bar widgets (#996) * Remove margin from bottom of bar charts (#1001) * Add check for user authentication in NewsFlash (#990) (#1003) * Fix subtitle param in CardEditor (#1005) (#1006) * Remove padding from bottom of stack bars (#1008) (#1009) * Open new widgets to production (#1012) (#1013) * Remove accident_count_by_driver_type from prod (#1016) * Update cards.const.ts * Add title and subtitle to heatmap widget (#1015) * fix the text in info button (make bigger) (#1020) (#1024) Co-authored-by: Barak Yakter <byakter@gmail,com> * fix the text in info button (make bigger) (#1020) (#1026) Co-authored-by: Barak Yakter <byakter@gmail,com> * Fix location qualification api use (#1022) (#1023) * Update generalConst.ts (#1027) * Add n12 org logo (#1031) (#1032) * Adjust titles for 2 widgets (#1036) Co-authored-by: Barak Yakter <byakter@gmail,com> * [Feat-1031] Add different color themes (for N12) (#1034) * Add n12 org logo (#1031) * Add Color Themes - N12 theme * Change the way patch request work (#1030) --------- Co-authored-by: shaked-hayek <85109951+shaked-hayek@users.noreply.github.com> Co-authored-by: danielsh28 <danielshely1@gmail.com> Co-authored-by: carmelp16 <46032304+carmelp16@users.noreply.github.com> Co-authored-by: EyalIlan <55767736+EyalIlan@users.noreply.github.com> Co-authored-by: EyalIlan <eyalilan8@gmail.com> Co-authored-by: Shai2022 <106345640+Shai2022@users.noreply.github.com> Co-authored-by: BarVolunteering <58947331+BarVolunteering@users.noreply.github.com> Co-authored-by: byakter <109795934+byakter@users.noreply.github.com> Co-authored-by: Barak Yakter <byakter@gmail,com>
atalyaalon
added a commit
that referenced
this pull request
Feb 21, 2024
* [Feat-885] Add selection for stack bar graphs (#935) * Added stacked bar widgets a checkbox option * Add option to choose colors when changing displayed bars * Changed any to proper type, make number of bar generic and add function createBarWidget * Fix bug of changed values when closing card editor * PR review changes * Remove redundent imports * add conditional label, refactor utils (#938) Co-authored-by: Daniel Shely <> * Update .env.staging (#947) * Add critical indication (#948) * Added image * Added critical icon based on field value * Added critical option to the filter panel * Added enum value * Had to increase width * Added local critical filter * Added field to model * add alt attrinbte on image tag (#951) * Update .env.staging (#952) * Make critical filter non local (#958) * sufficient condition * Use object for fetch args * Send params in object format * Make fields optional * don't use "any" type hint * Update News.tsx (#961) * Update news-flash-store.ts (#962) * Update News.tsx * Update thank-you-names.csv * transaction dialog box (#966) Co-authored-by: EyalIlan <eyalilan8@gmail.com> * [Feat-925] Add location approval feature (#969) * initial feature commit with icon and new field * Added icon choice and display * Move critical icon * Add location change button * Make critical icon transperent * replace critical.gif with svg * Window open pressing button, seperated newsFlash comp to new file * Added user info * Status icon and buttons * Added map choice (need to finish with saving data) * Saving location and qualificaion data * Added manual option for location qualification and added user change * Fix responsibilty issue between the two files * Split Search city to 2 files * Spacing and page look * Changed initialLocation to be a function, and improved onClose location window * Split radio buttons to seperate file * updated put function for news flash --------- Co-authored-by: Daniel Shely <> * Feature add transcrption 4 widgets 957 (#968) * transaction dialog box * show transaction icon only widgets that has transaction * add copy image to transaction box * add widget vision_10_30_90 (#972) * Feature widget vision zero 10 50 90 (#975) * add widget vision_10_30_90 * change widget 10_30_90 to 10_50_90 * change the location of the start command in package.json (#977) * change the location of the start command in package.json change the location of the start command after receive this error: /usr/local/bin/node: bad option: --openssl-legacy-provider * add npx browserslist@latest --update-db before start the docker * add logo (#979) * add natun square logo (#982) * add widget lower bar (#981) * update logo (#980) * Update Footer.tsx (#986) * add data-for-change (#988) * Delete src/assets/hasadna.png (#989) * Bug click twice to change news backround (#984) * add widget lower bar * fix news menu bar bug you need to click twice to make the news backround active * Add dev-to-prod auth server change (#950) * Spliting title and subtitle, making title bold (#995) * Change design in bar widgets (#996) * Remove margin from bottom of bar charts (#1001) * Add check for user authentication in NewsFlash (#990) (#1003) * Fix subtitle param in CardEditor (#1005) (#1006) * Remove padding from bottom of stack bars (#1008) (#1009) * Open new widgets to production (#1012) (#1013) * Remove accident_count_by_driver_type from prod (#1016) * Update cards.const.ts * Add title and subtitle to heatmap widget (#1015) * fix the text in info button (make bigger) (#1020) (#1024) Co-authored-by: Barak Yakter <byakter@gmail,com> * fix the text in info button (make bigger) (#1020) (#1026) Co-authored-by: Barak Yakter <byakter@gmail,com> * Fix location qualification api use (#1022) (#1023) * Update generalConst.ts (#1027) * Add n12 org logo (#1031) (#1032) * Adjust titles for 2 widgets (#1036) Co-authored-by: Barak Yakter <byakter@gmail,com> * [Feat-1031] Add different color themes (for N12) (#1034) * Add n12 org logo (#1031) * Add Color Themes - N12 theme * Change the way patch request work (#1030) --------- Co-authored-by: shaked-hayek <85109951+shaked-hayek@users.noreply.github.com> Co-authored-by: danielsh28 <danielshely1@gmail.com> Co-authored-by: carmelp16 <46032304+carmelp16@users.noreply.github.com> Co-authored-by: EyalIlan <55767736+EyalIlan@users.noreply.github.com> Co-authored-by: EyalIlan <eyalilan8@gmail.com> Co-authored-by: Shai2022 <106345640+Shai2022@users.noreply.github.com> Co-authored-by: BarVolunteering <58947331+BarVolunteering@users.noreply.github.com> Co-authored-by: byakter <109795934+byakter@users.noreply.github.com> Co-authored-by: Barak Yakter <byakter@gmail,com>
atalyaalon
added a commit
that referenced
this pull request
Feb 21, 2024
* [Feat-885] Add selection for stack bar graphs (#935) * Added stacked bar widgets a checkbox option * Add option to choose colors when changing displayed bars * Changed any to proper type, make number of bar generic and add function createBarWidget * Fix bug of changed values when closing card editor * PR review changes * Remove redundent imports * add conditional label, refactor utils (#938) Co-authored-by: Daniel Shely <> * Update .env.staging (#947) * Add critical indication (#948) * Added image * Added critical icon based on field value * Added critical option to the filter panel * Added enum value * Had to increase width * Added local critical filter * Added field to model * add alt attrinbte on image tag (#951) * Update .env.staging (#952) * Make critical filter non local (#958) * sufficient condition * Use object for fetch args * Send params in object format * Make fields optional * don't use "any" type hint * Update News.tsx (#961) * Update news-flash-store.ts (#962) * Update News.tsx * Update thank-you-names.csv * transaction dialog box (#966) Co-authored-by: EyalIlan <eyalilan8@gmail.com> * [Feat-925] Add location approval feature (#969) * initial feature commit with icon and new field * Added icon choice and display * Move critical icon * Add location change button * Make critical icon transperent * replace critical.gif with svg * Window open pressing button, seperated newsFlash comp to new file * Added user info * Status icon and buttons * Added map choice (need to finish with saving data) * Saving location and qualificaion data * Added manual option for location qualification and added user change * Fix responsibilty issue between the two files * Split Search city to 2 files * Spacing and page look * Changed initialLocation to be a function, and improved onClose location window * Split radio buttons to seperate file * updated put function for news flash --------- Co-authored-by: Daniel Shely <> * Feature add transcrption 4 widgets 957 (#968) * transaction dialog box * show transaction icon only widgets that has transaction * add copy image to transaction box * add widget vision_10_30_90 (#972) * Feature widget vision zero 10 50 90 (#975) * add widget vision_10_30_90 * change widget 10_30_90 to 10_50_90 * change the location of the start command in package.json (#977) * change the location of the start command in package.json change the location of the start command after receive this error: /usr/local/bin/node: bad option: --openssl-legacy-provider * add npx browserslist@latest --update-db before start the docker * add logo (#979) * add natun square logo (#982) * add widget lower bar (#981) * update logo (#980) * Update Footer.tsx (#986) * add data-for-change (#988) * Delete src/assets/hasadna.png (#989) * Bug click twice to change news backround (#984) * add widget lower bar * fix news menu bar bug you need to click twice to make the news backround active * Add dev-to-prod auth server change (#950) * Spliting title and subtitle, making title bold (#995) * Change design in bar widgets (#996) * Remove margin from bottom of bar charts (#1001) * Add check for user authentication in NewsFlash (#990) (#1003) * Fix subtitle param in CardEditor (#1005) (#1006) * Remove padding from bottom of stack bars (#1008) (#1009) * Open new widgets to production (#1012) (#1013) * Remove accident_count_by_driver_type from prod (#1016) * Update cards.const.ts * Add title and subtitle to heatmap widget (#1015) * fix the text in info button (make bigger) (#1020) (#1024) Co-authored-by: Barak Yakter <byakter@gmail,com> * fix the text in info button (make bigger) (#1020) (#1026) Co-authored-by: Barak Yakter <byakter@gmail,com> * Fix location qualification api use (#1022) (#1023) * Update generalConst.ts (#1027) * Add n12 org logo (#1031) (#1032) * Adjust titles for 2 widgets (#1036) Co-authored-by: Barak Yakter <byakter@gmail,com> * [Feat-1031] Add different color themes (for N12) (#1034) * Add n12 org logo (#1031) * Add Color Themes - N12 theme * Change the way patch request work (#1030) * [Feat-1031] Add theme for n12 (#1037) * Change the way patch request work * Add n12 org logo (#1031) * Add theme for N12 * Add theme for N12 * [Feat-1031] Add theme for n12 (#1041) * Change the way patch request work * Add n12 org logo (#1031) * Add theme for N12 * Add theme for N12 --------- Co-authored-by: shaked-hayek <85109951+shaked-hayek@users.noreply.github.com> Co-authored-by: danielsh28 <danielshely1@gmail.com> Co-authored-by: carmelp16 <46032304+carmelp16@users.noreply.github.com> Co-authored-by: EyalIlan <55767736+EyalIlan@users.noreply.github.com> Co-authored-by: EyalIlan <eyalilan8@gmail.com> Co-authored-by: Shai2022 <106345640+Shai2022@users.noreply.github.com> Co-authored-by: BarVolunteering <58947331+BarVolunteering@users.noreply.github.com> Co-authored-by: byakter <109795934+byakter@users.noreply.github.com> Co-authored-by: Barak Yakter <byakter@gmail,com>
atalyaalon
added a commit
that referenced
this pull request
Feb 21, 2024
* [Feat-885] Add selection for stack bar graphs (#935) * Added stacked bar widgets a checkbox option * Add option to choose colors when changing displayed bars * Changed any to proper type, make number of bar generic and add function createBarWidget * Fix bug of changed values when closing card editor * PR review changes * Remove redundent imports * add conditional label, refactor utils (#938) Co-authored-by: Daniel Shely <> * Update .env.staging (#947) * Add critical indication (#948) * Added image * Added critical icon based on field value * Added critical option to the filter panel * Added enum value * Had to increase width * Added local critical filter * Added field to model * add alt attrinbte on image tag (#951) * Update .env.staging (#952) * Make critical filter non local (#958) * sufficient condition * Use object for fetch args * Send params in object format * Make fields optional * don't use "any" type hint * Update News.tsx (#961) * Update news-flash-store.ts (#962) * Update News.tsx * Update thank-you-names.csv * transaction dialog box (#966) Co-authored-by: EyalIlan <eyalilan8@gmail.com> * [Feat-925] Add location approval feature (#969) * initial feature commit with icon and new field * Added icon choice and display * Move critical icon * Add location change button * Make critical icon transperent * replace critical.gif with svg * Window open pressing button, seperated newsFlash comp to new file * Added user info * Status icon and buttons * Added map choice (need to finish with saving data) * Saving location and qualificaion data * Added manual option for location qualification and added user change * Fix responsibilty issue between the two files * Split Search city to 2 files * Spacing and page look * Changed initialLocation to be a function, and improved onClose location window * Split radio buttons to seperate file * updated put function for news flash --------- Co-authored-by: Daniel Shely <> * Feature add transcrption 4 widgets 957 (#968) * transaction dialog box * show transaction icon only widgets that has transaction * add copy image to transaction box * add widget vision_10_30_90 (#972) * Feature widget vision zero 10 50 90 (#975) * add widget vision_10_30_90 * change widget 10_30_90 to 10_50_90 * change the location of the start command in package.json (#977) * change the location of the start command in package.json change the location of the start command after receive this error: /usr/local/bin/node: bad option: --openssl-legacy-provider * add npx browserslist@latest --update-db before start the docker * add logo (#979) * add natun square logo (#982) * add widget lower bar (#981) * update logo (#980) * Update Footer.tsx (#986) * add data-for-change (#988) * Delete src/assets/hasadna.png (#989) * Bug click twice to change news backround (#984) * add widget lower bar * fix news menu bar bug you need to click twice to make the news backround active * Add dev-to-prod auth server change (#950) * Spliting title and subtitle, making title bold (#995) * Change design in bar widgets (#996) * Remove margin from bottom of bar charts (#1001) * Add check for user authentication in NewsFlash (#990) (#1003) * Fix subtitle param in CardEditor (#1005) (#1006) * Remove padding from bottom of stack bars (#1008) (#1009) * Open new widgets to production (#1012) (#1013) * Remove accident_count_by_driver_type from prod (#1016) * Update cards.const.ts * Add title and subtitle to heatmap widget (#1015) * fix the text in info button (make bigger) (#1020) (#1024) Co-authored-by: Barak Yakter <byakter@gmail,com> * fix the text in info button (make bigger) (#1020) (#1026) Co-authored-by: Barak Yakter <byakter@gmail,com> * Fix location qualification api use (#1022) (#1023) * Update generalConst.ts (#1027) * Add n12 org logo (#1031) (#1032) * Adjust titles for 2 widgets (#1036) Co-authored-by: Barak Yakter <byakter@gmail,com> * [Feat-1031] Add different color themes (for N12) (#1034) * Add n12 org logo (#1031) * Add Color Themes - N12 theme * Change the way patch request work (#1030) * [Feat-1031] Add theme for n12 (#1037) * Change the way patch request work * Add n12 org logo (#1031) * Add theme for N12 * Add theme for N12 * [Feat-1031] Add theme for n12 (#1041) * Change the way patch request work * Add n12 org logo (#1031) * Add theme for N12 * Add theme for N12 * [Feat 1031] add theme for n12 - fixed (#1042) --------- Co-authored-by: shaked-hayek <85109951+shaked-hayek@users.noreply.github.com> Co-authored-by: danielsh28 <danielshely1@gmail.com> Co-authored-by: carmelp16 <46032304+carmelp16@users.noreply.github.com> Co-authored-by: EyalIlan <55767736+EyalIlan@users.noreply.github.com> Co-authored-by: EyalIlan <eyalilan8@gmail.com> Co-authored-by: Shai2022 <106345640+Shai2022@users.noreply.github.com> Co-authored-by: BarVolunteering <58947331+BarVolunteering@users.noreply.github.com> Co-authored-by: byakter <109795934+byakter@users.noreply.github.com> Co-authored-by: Barak Yakter <byakter@gmail,com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.