Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding rtl theme #740

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Conversation

EyalIlan
Copy link
Collaborator

@EyalIlan EyalIlan commented Aug 9, 2021

closes #704

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
src/index.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
@SejoB
Copy link
Collaborator

SejoB commented Aug 9, 2021

also don't forget assign yourself to PR

}, [i18n, theme, theme.direction, appDir]);
// theme.direction = appDir;
// , theme.direction
}, [i18n, theme, appDir]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

src/App.tsx Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@yuvalbl yuvalbl closed this Oct 6, 2021
@yuvalbl yuvalbl reopened this Oct 6, 2021
@yuvalbl yuvalbl merged commit fa4cf2c into dev Oct 13, 2021
@yuvalbl yuvalbl deleted the bug-704-floating-label-not-changing-direction branch October 13, 2021 15:27
@yuvalbl
Copy link
Collaborator

yuvalbl commented Oct 13, 2021

This PR messed up widget background on staging (see attachment)
we will postpone treatment for this issue to MS 0.11/12
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Floating label not changing direction
4 participants