News Flash API

[atalyaalon]

currently no pagination in News Flash API
(See this issue in FE)

Hence we want to modify News Flash API as described here, without changing current functionality.
If current functionality is changed, please coordinate with SejoB ( FE tem) for adjustments needed in FE of current API.

[atalyaalon]

@ziv17 this is currently top priority.

[atalyaalon]

Also. Previous BE volunteer working on this and talked to SejoB (Sergey) wrote the following:

[atalyaalon]

relevant pr that removes unused API: https://github.com/data-for-change/anyway/pull/2644/files

[ziv17]

Hi @atalyaalon ,
The PR that I prapare should build upon PR #2644? (or it will be merged before that PR?)
Which news-flash APIs, or URLs are included in the issue?

[atalyaalon]

@ziv17 I'm working on merging it today, so you'll build upon it (After merge)
This issue is on API urls in /api/news-flash
Note that exist a specific url of specific id: /api/news-flash/<int:news_flash_id>
As mentioned we want to change this api and make sure we're adding the offset.

[atalyaalon]

@ziv17 merged :) you can use dev branch

[ziv17]

Hi @atalyaalon ,
Do we want to keep both offset and pageNumer (and limit with pageSize)?
If not, to deprecate offset and limit?

[atalyaalon]

@ziv17 I suggest coordinating this decision with Sergey.
We can deprecate some fields, but make sure we're either backward compatible OR that we modify FE and BE at the same time.