Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2697 nf api pagination #2707

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

ziv17
Copy link
Collaborator

@ziv17 ziv17 commented Sep 30, 2024

Closes #2697

For newsFlashId get the date of the record with the given id and calculate offset according to its date
@ziv17 ziv17 force-pushed the 2697-nf-api-pagination branch from 6b764a8 to 695a04b Compare September 30, 2024 16:54
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.79%. Comparing base (400af13) to head (695a04b).
Report is 108 commits behind head on dev.

Files with missing lines Patch % Lines
anyway/views/news_flash/api.py 54.16% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2707      +/-   ##
==========================================
- Coverage   53.22%   52.79%   -0.44%     
==========================================
  Files         119      122       +3     
  Lines        9924    10123     +199     
==========================================
+ Hits         5282     5344      +62     
- Misses       4642     4779     +137     
Flag Coverage Δ
unittests 52.79% <54.16%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atalyaalon atalyaalon merged commit 4f138c6 into data-for-change:dev Oct 6, 2024
3 checks passed
@ziv17 ziv17 deleted the 2697-nf-api-pagination branch February 9, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

News Flash API
3 participants